Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fwrite csvy #3536

Merged
merged 8 commits into from
May 11, 2019
Merged

Fwrite csvy #3536

merged 8 commits into from
May 11, 2019

Conversation

MichaelChirico
Copy link
Member

@MichaelChirico MichaelChirico commented May 3, 2019

Closes #3534

@codecov
Copy link

codecov bot commented May 4, 2019

Codecov Report

Merging #3536 into master will increase coverage by <.01%.
The diff coverage is 100%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #3536      +/-   ##
==========================================
+ Coverage   97.17%   97.18%   +<.01%     
==========================================
  Files          66       66              
  Lines       12647    12670      +23     
==========================================
+ Hits        12290    12313      +23     
  Misses        357      357
Impacted Files Coverage Δ
R/fwrite.R 98.75% <100%> (+0.5%) ⬆️
R/fread.R 99.6% <100%> (ø) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 7810b22...ade071b. Read the comment docs.

@codecov
Copy link

codecov bot commented May 4, 2019

Codecov Report

Merging #3536 into master will increase coverage by <.01%.
The diff coverage is 100%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #3536      +/-   ##
==========================================
+ Coverage   97.42%   97.43%   +<.01%     
==========================================
  Files          66       66              
  Lines       12682    12705      +23     
==========================================
+ Hits        12356    12379      +23     
  Misses        326      326
Impacted Files Coverage Δ
R/fread.R 100% <100%> (ø) ⬆️
R/fwrite.R 98.75% <100%> (+0.5%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update bc17059...9d42b63. Read the comment docs.

@MichaelChirico
Copy link
Member Author

Hmm not sure why the failure on AppVeyor... must be something to do with eol...

@MichaelChirico
Copy link
Member Author

ok fixed it... I'll add a \r\n eol test when I'm back to my machine

@MichaelChirico
Copy link
Member Author

OK, ready to merge from my side, pending approval

@mattdowle mattdowle added this to the 1.12.4 milestone May 11, 2019
@mattdowle mattdowle merged commit e6289e1 into master May 11, 2019
@mattdowle mattdowle deleted the fwrite_csvy branch May 11, 2019 00:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add CSVY support for fwrite
2 participants