-
Notifications
You must be signed in to change notification settings - Fork 991
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
colClasses correspond to select #3547
Conversation
Codecov Report
@@ Coverage Diff @@
## master #3547 +/- ##
=========================================
+ Coverage 97.32% 97.42% +0.1%
=========================================
Files 66 66
Lines 12629 12676 +47
=========================================
+ Hits 12291 12350 +59
+ Misses 338 326 -12
Continue to review full report at Codecov.
|
neat idea! |
on closer read I'm a bit confused. can't we just allow select to be used exactly as colClasses? just pass colClasses to select instead of colClasses and it will also subset to only the mentioned columns? |
That is what it does. It's exactly as colClasses when colClasses is a vector. When select is used like this, colClasses can't be used at the same time. Makes sense? |
Am I misreading this error?
|
As
as
|
Why not :
I expanded my comment above a bit regarding the selection order. We can take our time to consider this one. I won't merge yet. |
for the same reason as |
Or, instead of :
how about :
When |
…evel to avoid forder afterwards and deal with order of columns inside select=list() too
@MichaelChirico Better? |
I think what I was missing is the part where But if order matters, you're just consigned to using select-as-vector now? (haven't gotten a chance to read carefully) |
Added comments; front-end API looks good 👍 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM!
Closes #1426
Follow up to #2545
datatable.colClassesSelectOrder
was attempted in this PR)colClasses
to be specified insideselect
directly in one place