Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #3079
Follow up to #3546
gmedian now retains the class, other than for integer64 since it always returns double.
Also reduced lines of code in gmedian by adding an integer64 case to quickselect.c, moving the 2nd-half minimum loops into quickselect.c, and finding location of median inside quickselect rather than passing that in. Existing test 1579 covered int, double, integer64 and na.rm cases nicely.
R API raised outside loops in gmedian (since altrep R 3.5 greater overhead).
A few trailing spaces removed (my editor does that on save).
A few unrelated tests tweaked to pass in dev mode when data.table is not installed.
Checked all gforce function retain attributes. Added comment to the only one that doesn't (
gvarsd1
) since class unlikely applicable for sd/var.