Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

adds support for complex vectors to shift, part of #3690 #3693

Merged
merged 7 commits into from
Jul 17, 2019
Merged

Conversation

MichaelChirico
Copy link
Member

@MichaelChirico MichaelChirico commented Jul 10, 2019

@codecov
Copy link

codecov bot commented Jul 11, 2019

Codecov Report

Merging #3693 into master will increase coverage by <.01%.
The diff coverage is 100%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #3693      +/-   ##
==========================================
+ Coverage   98.25%   98.25%   +<.01%     
==========================================
  Files          69       69              
  Lines       13088    13098      +10     
==========================================
+ Hits        12860    12870      +10     
  Misses        228      228
Impacted Files Coverage Δ
src/shift.c 99.09% <100%> (+0.13%) ⬆️
R/coalesce.R 100% <0%> (ø) ⬆️
src/coalesce.c 100% <0%> (ø) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 4e3868b...f991b17. Read the comment docs.

@codecov
Copy link

codecov bot commented Jul 11, 2019

Codecov Report

Merging #3693 into master will increase coverage by <.01%.
The diff coverage is 100%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #3693      +/-   ##
==========================================
+ Coverage   98.26%   98.26%   +<.01%     
==========================================
  Files          69       69              
  Lines       13243    13257      +14     
==========================================
+ Hits        13013    13027      +14     
  Misses        230      230
Impacted Files Coverage Δ
src/shift.c 99.09% <100%> (+0.13%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update b4057af...1ca7bbb. Read the comment docs.

@MichaelChirico MichaelChirico changed the title WIP: adds support for complex vectors to shift, part of #3690 adds support for complex vectors to shift, part of #3690 Jul 11, 2019
@mattdowle mattdowle added this to the 1.12.4 milestone Jul 17, 2019
@mattdowle mattdowle merged commit e5db9bb into master Jul 17, 2019
@mattdowle mattdowle deleted the cplx_shift branch July 17, 2019 20:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants