Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

retain NA in character when joining to factor #3810

Merged
merged 1 commit into from
Sep 2, 2019

Conversation

mattdowle
Copy link
Member

@mattdowle mattdowle commented Sep 2, 2019

Closes #3809
Fixes VIM in #3581

@mattdowle mattdowle added this to the 1.12.4 milestone Sep 2, 2019
@mattdowle mattdowle mentioned this pull request Sep 2, 2019
31 tasks
@codecov
Copy link

codecov bot commented Sep 2, 2019

Codecov Report

Merging #3810 into master will increase coverage by <.01%.
The diff coverage is 100%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #3810      +/-   ##
==========================================
+ Coverage   99.41%   99.41%   +<.01%     
==========================================
  Files          71       71              
  Lines       13262    13265       +3     
==========================================
+ Hits        13185    13188       +3     
  Misses         77       77
Impacted Files Coverage Δ
R/bmerge.R 100% <100%> (ø) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 4dd9548...64587f3. Read the comment docs.

@mattdowle mattdowle merged commit 3d0dc92 into master Sep 2, 2019
@mattdowle mattdowle deleted the join_na_character_to_na_factor branch September 2, 2019 08:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Join NA_character_ to factor broken in dev
1 participant