Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

coalesce(NULL,foo) returns NULL #3826

Merged
merged 1 commit into from
Sep 5, 2019
Merged

coalesce(NULL,foo) returns NULL #3826

merged 1 commit into from
Sep 5, 2019

Conversation

mattdowle
Copy link
Member

@mattdowle mattdowle commented Sep 5, 2019

Part resolves mlr for #3581
This was only revealed because data.table::coalesce masks BBmisc::coalesce in this case (dplyr::coalesce in others). In other words, by exporting coalesce we are inflicting the new function on packages like mlr. There was a suggestion (#3754) that we should rename coalesce as fcoalesce, so that was a good idea (reopened). We can still optimize coalesce to fcoalesce within DT[...].

@mattdowle mattdowle added this to the 1.12.4 milestone Sep 5, 2019
@mattdowle mattdowle mentioned this pull request Sep 5, 2019
31 tasks
@codecov
Copy link

codecov bot commented Sep 5, 2019

Codecov Report

Merging #3826 into master will not change coverage.
The diff coverage is 100%.

Impacted file tree graph

@@           Coverage Diff           @@
##           master    #3826   +/-   ##
=======================================
  Coverage   99.42%   99.42%           
=======================================
  Files          71       71           
  Lines       13399    13399           
=======================================
  Hits        13322    13322           
  Misses         77       77
Impacted Files Coverage Δ
src/coalesce.c 100% <100%> (ø) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 96a6fcd...ce61546. Read the comment docs.

@mattdowle mattdowle merged commit 4886f30 into master Sep 5, 2019
@mattdowle mattdowle deleted the coalesce_null branch September 5, 2019 20:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant