Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Part resolves
mlr
for #3581This was only revealed because
data.table::coalesce
masksBBmisc::coalesce
in this case (dplyr::coalesce
in others). In other words, by exporting coalesce we are inflicting the new function on packages like mlr. There was a suggestion (#3754) that we should renamecoalesce
asfcoalesce
, so that was a good idea (reopened). We can still optimizecoalesce
tofcoalesce
withinDT[...]
.