invalid on= downgraded from error to warning, and retain list names #3854
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## master #3854 +/- ##
==========================================
+ Coverage 99.42% 99.42% +<.01%
==========================================
Files 71 71
Lines 13412 13416 +4
==========================================
+ Hits 13335 13339 +4
Misses 77 77
Continue to review full report at Codecov.
|
mattdowle
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolves
batchtools(andparallelMapwhich usesbatchtools) in #3581Two separate issues were affecting
batchtools. Resolved both in the same PR.Invalid
on=natural join (i.e.on=provided withouti=buton=not a list) downgraded to warning thaton=is being ignored as before to return the same result as 1.12.2.If a plain list was passed to
as.data.table()and that list had names containing blanks, then those blanks were being auto named with "V1" etc. This tripped upbatchtoolsbecause it constructs an expression stored in a data.table column with ado.call()and the "V1" in the column name created an invalid parameter. Therefore changedas.data.table.list()back to retain the list names as-is even if they contain blanks or duplicates (which seems very reasonable), just as v1.12.2 did.The change to test 2061 is related to the construction of the
yto compare against. As it was a new test in this dev release, the construction of y relied on dev behavior which didn't retain list names. I changed the construction ofyto be more direct and the test itself doesn't change.