group varying factor levels fixed #3906
Conversation
Codecov Report
@@ Coverage Diff @@
## master #3906 +/- ##
==========================================
+ Coverage 99.42% 99.43% +<.01%
==========================================
Files 72 72
Lines 13502 13548 +46
==========================================
+ Hits 13425 13471 +46
Misses 77 77
Continue to review full report at Codecov.
|
| const bool sourceIsFactor=isFactor(source), targetIsFactor=isFactor(target); | ||
| if (sourceIsFactor && targetIsFactor) { | ||
| // TODO: ^^ could be || in future; assign is already handling that so leave that for now. Then move more of assign to call here. | ||
| if (!sourceIsFactor || !targetIsFactor) { |
There was a problem hiding this comment.
this is always false, maybe just wrapping into /* ... */ instead?
There was a problem hiding this comment.
it's there for the future when the todo in that comment is done
There was a problem hiding this comment.
make sense, but could be commented out code block too.
would be good to have a followup issue and link it from there
There was a problem hiding this comment.
It could be but I'd prefer not to. Ok?
There was a problem hiding this comment.
Of all the lines in this PR, this is the least significant to pick up on.
Closes #2199
Closes #2522