Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Print Option: Print columns that fit in single console without wrapping #4074
Print Option: Print columns that fit in single console without wrapping #4074
Changes from 30 commits
c1a7c74
e1c8767
7bccbbd
7ebf6a7
a89dda8
fd9c8d9
90a9ff1
a9f47f0
debbbc6
22f4c9e
c5c0fe0
ea4051f
3408884
def64c7
03f0356
2bc1544
f604791
510b9a4
ca6105a
1ef864c
4631758
4927f69
0624921
3d0affa
e6cc430
4c467b2
8025bad
bd11f04
0869c95
687f5ff
7848984
0289bee
32f3b64
d85ec9a
037a5c9
f8df273
13ced05
0c002dc
45e7c41
020d56f
File filter
Filter by extension
Conversations
Jump to
There are no files selected for viewing
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
another micro-optimization -- we can do
+2 else 0L
. I thinkif(!row.names)
the+1L
in the next step is wrong. However I also just noticed this:#4083
So even if
row.names=FALSE
, it could still occupy some characters. I think you can safely ignore that in this PR, rather than complicating logic to detect whether---
will be present.There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I wondered about the
---
but hadn't done anything about it yet. Imagine we'll want to wait for that to be resolved before deciding any padding.I believe the
+1L
incumsum(dt_widths + 1L)
should account for the space between the row names and the first column instead of needing to add another to therownum_width
.There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
But I'll take off the
+1L
after therownum_width
bc I think you are right that it is unnecessary.There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think the
+1L
is right whenrow.names=TRUE