Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

be sure to unlock objects returned during grouping #4160

Merged
merged 1 commit into from
Jan 8, 2020

Conversation

MichaelChirico
Copy link
Member

Part of #4159

I'm not sure this is the best way to do this, open to alternatives. But I did it recursively since we can really control how "deep down" any usages of .SD to be returned would be.

@codecov
Copy link

codecov bot commented Jan 5, 2020

Codecov Report

Merging #4160 into master will increase coverage by <.01%.
The diff coverage is 100%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #4160      +/-   ##
==========================================
+ Coverage   99.54%   99.54%   +<.01%     
==========================================
  Files          72       72              
  Lines       13915    13921       +6     
==========================================
+ Hits        13851    13857       +6     
  Misses         64       64
Impacted Files Coverage Δ
R/data.table.R 100% <100%> (ø) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update d9b7ad5...516f22f. Read the comment docs.

@mattdowle mattdowle added this to the 1.12.9 milestone Jan 8, 2020
@mattdowle mattdowle merged commit 11ab05a into master Jan 8, 2020
@mattdowle mattdowle deleted the sd-unlock-group branch January 8, 2020 00:29
@jangorecki jangorecki modified the milestones: 1.12.11, 1.12.9 May 26, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants