Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

better error message for missing j in cube #4282

Merged
merged 4 commits into from
Apr 15, 2021
Merged

better error message for missing j in cube #4282

merged 4 commits into from
Apr 15, 2021

Conversation

MichaelChirico
Copy link
Member

Ran into this today -- before this fix, the missing j was being passed as jj to groupingsets and we'd get an error from all.vars referencing a missing jj. Better to reference j since that's part of args(cube.data.table).

@codecov
Copy link

codecov bot commented Mar 6, 2020

Codecov Report

Merging #4282 (ad7b1f2) into master (54082e4) will increase coverage by 0.00%.
The diff coverage is 100.00%.

❗ Current head ad7b1f2 differs from pull request most recent head 1e9c8ec. Consider uploading reports for the commit 1e9c8ec to get more accurate results
Impacted file tree graph

@@           Coverage Diff           @@
##           master    #4282   +/-   ##
=======================================
  Coverage   99.42%   99.42%           
=======================================
  Files          73       73           
  Lines       14430    14432    +2     
=======================================
+ Hits        14347    14349    +2     
  Misses         83       83           
Impacted Files Coverage Δ
R/groupingsets.R 100.00% <100.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 54082e4...1e9c8ec. Read the comment docs.

NEWS.md Outdated Show resolved Hide resolved
@mattdowle mattdowle added this to the 1.14.1 milestone Apr 15, 2021
@mattdowle mattdowle merged commit c2b55bf into master Apr 15, 2021
@mattdowle mattdowle deleted the cube-missing-j branch April 15, 2021 05:54
@jangorecki jangorecki modified the milestones: 1.14.9, 1.15.0 Oct 29, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants