Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

test.data.table manual says to run in clean environment #4352

Closed
wants to merge 1 commit into from

Conversation

jangorecki
Copy link
Member

closes #3705

@codecov
Copy link

codecov bot commented Apr 3, 2020

Codecov Report

Merging #4352 into master will not change coverage by %.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master    #4352   +/-   ##
=======================================
  Coverage   99.61%   99.61%           
=======================================
  Files          72       72           
  Lines       13916    13916           
=======================================
  Hits        13862    13862           
  Misses         54       54           

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update b1b1832...244f317. Read the comment docs.

@jangorecki jangorecki changed the title address #3705 test.data.table manual says to run in clean environment Apr 5, 2020
@mattdowle
Copy link
Member

What does "clean environment" mean precisely? Should users rm(*), or does it mean "fresh new R session"? If the latter, what if the very reason the user wants to run test.data.table() is if they want to test in that particular session; maybe they think some packages might be causing bad interaction effects with data.table, or that their R session may be corrupted or something.

I really think #3705 should be fixed directly. I thought it already ran in its own independent scope, but clearly it must still be able to reach .GlobalEnv. If there's not a way to isolate it from .GlobalEnv, then test 1894 could be made robust to this.

@mattdowle mattdowle closed this May 18, 2021
@mattdowle mattdowle deleted the test-cleanenv branch May 18, 2021 09:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

tests fail if z in .GlobalEnv
2 participants