Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

cbindlist, mergelist #4370

Open
wants to merge 121 commits into
base: master
Choose a base branch
from
Open

cbindlist, mergelist #4370

wants to merge 121 commits into from

Conversation

jangorecki
Copy link
Member

@jangorecki jangorecki commented Apr 10, 2020

partially, because not hooked in [.data.table, this should go as a separate PR:


extra testing vs SQLite db, for how="left|inner|full|right"

Rscript inst/tests/sqlite.Rraw.manual

@jangorecki jangorecki added the WIP label Apr 10, 2020
@jangorecki jangorecki changed the title cbindlist cbindlist, mergelist Apr 10, 2020
R/mergelist.R Outdated Show resolved Hide resolved
R/mergelist.R Outdated Show resolved Hide resolved
src/mergelist.c Outdated Show resolved Hide resolved
src/mergelist.c Outdated Show resolved Hide resolved
@jangorecki jangorecki linked an issue Apr 17, 2020 that may be closed by this pull request
Copy link

github-actions bot commented Aug 28, 2024

Comparison Plot

Generated via commit 5952dd8

Download link for the artifact containing the test results: ↓ atime-results.zip

Time taken to finish the standard R installation steps: 11 minutes and 17 seconds

Time taken to run atime::atime_pkg on the tests: 6 minutes and 9 seconds

@MichaelChirico
Copy link
Member

@jangorecki I broke this down into digestible parts with Graphite's gt split --by-hunk. It took 60-90 minutes. It would have been faster (e.g. 30 minutes) if I (1) understood the structure of the PR more intimately --> could more easily decide how to split the hunks (2) use EDITOR=emacs (or vim), nano is not suitable for that kind of editing 🥲

@jangorecki
Copy link
Member Author

Nice, I would be happy to do it myself but these days I am not able to volunteer my free time and there is no sponsor as in the past.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
5 participants