Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

droplevels for empty table and ordered factors #5185

Merged
merged 4 commits into from
Oct 5, 2021
Merged

Conversation

ben-schwen
Copy link
Member

@ben-schwen ben-schwen commented Sep 29, 2021

Closes #5184
Follows #647 and #5116

Partly addresses discussion #5116 (whats still open is the question whether the argument should be named is in.place or copy/copy.x

@codecov
Copy link

codecov bot commented Sep 29, 2021

Codecov Report

Merging #5185 (6338859) into master (8f0afcb) will increase coverage by 0.00%.
The diff coverage is 100.00%.

Impacted file tree graph

@@           Coverage Diff           @@
##           master    #5185   +/-   ##
=======================================
  Coverage   99.38%   99.38%           
=======================================
  Files          77       77           
  Lines       14540    14541    +1     
=======================================
+ Hits        14451    14452    +1     
  Misses         89       89           
Impacted Files Coverage Δ
R/fdroplevels.R 100.00% <100.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 8f0afcb...6338859. Read the comment docs.

@mattdowle mattdowle added this to the 1.14.3 milestone Oct 5, 2021
@mattdowle mattdowle merged commit cd81808 into master Oct 5, 2021
@mattdowle mattdowle deleted the droplevels_empty branch October 5, 2021 17:49
@jangorecki jangorecki modified the milestones: 1.14.9, 1.15.0 Oct 29, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

droplevels() fails with empty data.table
4 participants