Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

adding an atime test case Performance Regression with .N and := #PR5463 #6160

Closed
wants to merge 2 commits into from
Closed

adding an atime test case Performance Regression with .N and := #PR5463 #6160

Changes from 1 commit
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
3289d98
Update tests.R
DorisAmoakohene May 29, 2024
adf09d8
Update tests.R
DorisAmoakohene May 29, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
18 changes: 17 additions & 1 deletion .ci/atime/tests.R
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -119,6 +119,22 @@ test.list <- atime::atime_test_list(
data.table:::setDT(L)
},
Slow = "c4a2085e35689a108d67dacb2f8261e4964d7e12", # Parent of the first commit in the PR that fixes the issue (https://github.com/Rdatatable/data.table/commit/7cc4da4c1c8e568f655ab5167922dcdb75953801)
Fast = "1872f473b20fdcddc5c1b35d79fe9229cd9a1d15") # Last commit in the PR that fixes the issue (https://github.com/Rdatatable/data.table/pull/5427/commits)
Fast = "1872f473b20fdcddc5c1b35d79fe9229cd9a1d15"),# Last commit in the PR that fixes the issue (https://github.com/Rdatatable/data.table/pull/5427/commits)

#issue reported in: https://github.com/Rdatatable/data.table/issues/5424
#Fixed in: https://github.com/Rdatatable/data.table/pull/5463
tdhock marked this conversation as resolved.
Show resolved Hide resolved
"Performance Regression with .N and := #PR5463" = atime::atime_test(
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Based on the reviews I received from @tdhock on the three existing test cases, the title would be of the form '<Function/Operator/Symbol> improved in #PRNumber' for performance improvement cases ('Fast' and 'Slow' labels) or '<Function/Operator/Symbol> regression fixed in #PRNumber' for performance regressions ('Before', 'Regression', and 'Fixed' labels)

(also the term 'Performance' is omitted from the titles since it's a given and would be repeated for each case if we were to use it)

N = 10^seq(1, 4),
setup = {
set.seed(123L)
dt <- data.table(
id = seq_len(N),
val = rnorm(N))
dt
},
expr = data.table:::`[.data.table`(dt, , .(vs = (sum(val))), by = .(id)),
Before = "be2f72e6f5c90622fe72e1c315ca05769a9dc854",
Regression = "e793f53466d99f86e70fc2611b708ae8c601a451",
Fixed = "58409197426ced4714af842650b0cc3b9e2cb842")
tdhock marked this conversation as resolved.
Show resolved Hide resolved
)
# nolint end: undesirable_operator_linter.
Loading