Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix char.trunc with NA #6442

Merged
merged 6 commits into from
Aug 31, 2024
Merged

Fix char.trunc with NA #6442

merged 6 commits into from
Aug 31, 2024

Conversation

joshhwuu
Copy link
Member

Closes #6441

Copy link

github-actions bot commented Aug 30, 2024

Comparison Plot

Generated via commit 40f797b

Download link for the artifact containing the test results: ↓ atime-results.zip

Time taken to finish the standard R installation steps: 11 minutes and 36 seconds

Time taken to run atime::atime_pkg on the tests: 6 minutes and 0 seconds

@MichaelChirico MichaelChirico added this to the 1.16.2 milestone Aug 30, 2024
Copy link
Member

@MichaelChirico MichaelChirico left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thanks for the quick turnaround!

@MichaelChirico MichaelChirico merged commit 497b22a into master Aug 31, 2024
7 of 8 checks passed
@MichaelChirico MichaelChirico deleted the fix6441 branch August 31, 2024 01:25
MichaelChirico added a commit that referenced this pull request Aug 31, 2024
* omit NA in indices

* revisit

* better test

* change order

* NEWS

---------

Co-authored-by: Michael Chirico <chiricom@google.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

char.trunc fails with NA
2 participants