Add set-flag endpoint for assignment solutions

app/V1Module/presenters/AssignmentSolutionsPresenter.php

@@ -264,6 +264,72 @@ public function actionSetBonusPoints(string $id) {
     $this->sendSuccessResponse("OK");
   }
 
+  public function checkSetFlag(string $id) {
+    $solution = $this->assignmentSolutions->findOrThrow($id);
+    if (!$this->assignmentSolutionAcl->canSetFlag($solution)) {
+      throw new ForbiddenRequestException("You cannot change flags for this submission");
+    }
+  }
+
+  /**
+   * Set flag of the assignment solution.
+   * @POST
+   * @param string $id identifier of the solution
+   * @param string $flag name of the flag which should to be changed
+   * @Param(type="post", name="value", required=true, validation=boolean, description="True or false which should be set to given flag name")
+   * @throws NotFoundException
+   * @throws \Nette\Application\AbortException
+   * @throws \Exception
+   */
+  public function actionSetFlag(string $id, string $flag) {
+    $req = $this->getRequest();
+    $solution = $this->assignmentSolutions->findOrThrow($id);
+    if ($solution->getAssignment() === null) {
+      throw new NotFoundException("Assignment for solution '$id' was deleted");
+    }
+
+    if ($solution->getSolution()->getAuthor() === null) {
+      throw new NotFoundException("Author of solution '$id' was deleted");
+    }
+
+    // map of boolean flag names with the information about uniqueness
+    $knownBoolFlags = [
+      "accepted" => true,
+      "reviewed" => false
+    ];
+
+    if (!array_key_exists($flag, $knownBoolFlags)) {
+      throw new BadRequestException("Trying to set unknown boolean flag '$flag' to the solution");
+    }
+
+    // handle given flag
+    $unique = $knownBoolFlags[$flag];
+    if ($req->getPost("value") !== null) {
+      $value = filter_var($req->getPost("value"), FILTER_VALIDATE_BOOLEAN);
+      $solution->setFlag($flag, $value);
+
+      // handle unique flags
+      if ($unique && $value) {
+        // flag has to be set to false for all other submissions
+        $assignmentSubmissions = $this->assignmentSolutions->findSolutions($solution->getAssignment(), $solution->getSolution()->getAuthor());
+        foreach ($assignmentSubmissions as $assignmentSubmission) {
+          $assignmentSubmission->setFlag($flag, false);
+        }
+      }
+    }
+
+    // finally flush all changed to the database
+    $this->assignmentSolutions->flush();
+
+    // forward to student statistics of group
+    $groupOfSubmission = $solution->getAssignment()->getGroup();
+    if ($groupOfSubmission === null) {
+      throw new NotFoundException("Group for assignment '$id' was not found");
+    }
+
+    $this->forward('Groups:studentsStats', $groupOfSubmission->getId(), $solution->getSolution()->getAuthor()->getId());
+  }
+
   public function checkSetAccepted(string $id) {
     $solution = $this->assignmentSolutions->findOrThrow($id);
     if (!$this->assignmentSolutionAcl->canSetAccepted($solution)) {
@@ -274,7 +340,7 @@ public function checkSetAccepted(string $id) {
   /**
    * Set solution of student as accepted, this solution will be then presented as the best one.
    * @POST
-   * @param string $id identifier of the submission
+   * @param string $id identifier of the solution
    * @throws \Nette\Application\AbortException
    * @throws NotFoundException
    */
@@ -317,7 +383,7 @@ public function checkUnsetAccepted(string $id) {
   /**
    * Set solution of student as unaccepted if it was.
    * @DELETE
-   * @param string $id identifier of the submission
+   * @param string $id identifier of the solution
    * @throws \Nette\Application\AbortException
    * @throws NotFoundException
    */

app/V1Module/router/RouterFactory.php

@@ -301,6 +301,8 @@ private static function createAssignmentSolutionsRoutes(string $prefix): RouteLi
     $router[] = new DeleteRoute("$prefix/<id>", "AssignmentSolutions:deleteSolution");
     $router[] = new PostRoute("$prefix/<id>/bonus-points", "AssignmentSolutions:setBonusPoints");
     $router[] = new GetRoute("$prefix/<id>/evaluations", "AssignmentSolutions:evaluations");
+    $router[] = new PostRoute("$prefix/<id>/set-flag/<flag>", "AssignmentSolutions:setFlag");
+    $router[] = new PostRoute("$prefix/<id>/set-accepted", "AssignmentSolutions:setAccepted");
     $router[] = new PostRoute("$prefix/<id>/set-accepted", "AssignmentSolutions:setAccepted");
     $router[] = new DeleteRoute("$prefix/<id>/unset-accepted", "AssignmentSolutions:unsetAccepted");
     $router[] = new PostRoute("$prefix/<id>/resubmit", "Submit:resubmit");

app/V1Module/security/ACL/IAssignmentSolutionPermissions.php

@@ -11,6 +11,7 @@ function canViewDetail(AssignmentSolution $assignmentSolution): bool;
   function canDelete(AssignmentSolution $assignmentSolution): bool;
   function canSetBonusPoints(AssignmentSolution $assignmentSolution): bool;
   function canSetAccepted(AssignmentSolution $assignmentSolution): bool;
+  function canSetFlag(AssignmentSolution $assignmentSolution): bool;
   function canViewResubmissions(AssignmentSolution $assignmentSolution): bool;
 
   function canViewEvaluation(AssignmentSolution $assignmentSolution): bool;

app/config/permissions.neon

@@ -15,7 +15,7 @@ roles:
 
     - name: superadmin
 
-permissions:    
+permissions:
     - allow: true
       role: scope-master
 
@@ -393,6 +393,7 @@ permissions:
           - delete
           - setBonusPoints
           - setAccepted
+          - setFlag
           - downloadResultArchive
       conditions:
           - assignmentSolution.isSupervisor

app/model/entity/AssignmentSolution.php

@@ -26,6 +26,7 @@
 class AssignmentSolution
 {
   use MagicAccessors;
+  use FlagAccessor;
 
   const JOB_TYPE = "student";
 

app/model/entity/base/FlagAccessor.php

@@ -2,6 +2,7 @@
 
 namespace App\Model\Entity;
 
+use Exception;
 use ReflectionClass;
 
 trait FlagAccessor {