-
Notifications
You must be signed in to change notification settings - Fork 98
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Review request: Petchey, Plebani, Pennekamp #15
Review request: Petchey, Plebani, Pennekamp #15
Conversation
Conflicts: code/report.Rmd
@yoavram please can you send me an image of your workspace after all the code is run?
|
Sure! I get what you get, I think: > type.convert
function (x, na.strings = "NA", as.is = FALSE, dec = ".", numerals = c("allow.loss",
"warn.loss", "no.loss"))
.External2(C_typeconvert, x, na.strings, as.is, dec, match.arg(numerals))
<bytecode: 0x000000001be04680>
<environment: namespace:utils> See attached zipped RData file |
Yes, I still don't know why we're getting different results. But something to do with treatment of character variables. |
REVIEWER 1 As far as I'm concerned and following what @tpoisot wrote above (31 Marh 2016) this is a minor issue. I believe the ms can be accepted. |
I've been very busy but I will be able to handle this tomorrow. Will On Mon, 4 Apr 2016 at 21:59 Yoav Ram notifications@github.com wrote:
|
@FedericoV Thanks. Please be sure to use the latest commit. |
The last commit reproduces beautifully. The report is also very well done - I don't use R at all, but I could follow almost all the steps/code. I am satisfied with the paper in its current form. The only minor comments I have is that I would be curious to know how come the results for the Lyapunov coefficients was slightly different, and the exact procedure through which the zeros were removed. Also - another comment. Is it possible to have within-document links? For example, when you talk about (red line in Fig. S1b) it would be handy to have a link that brought you to the relevant figure immediately. |
@FedericoV noted -- I think if @opetchey et al. have an idea, it can go in the ms. If not, since the differences are not really big, we can leave with this and move on to the next step. As for the within-document links: maybe using |
Agreed completely. On Tue, 5 Apr 2016 at 19:54 Timothée Poisot notifications@github.com
|
@tpoisot I edited my first post here suggesting we accept this reproduction. It's very well done, the code is very readable. My suggestions are very minor and the reproduction is more than acceptable in its current form. |
EDITOR Accepted, April 13, 2016. Congratulations @opetchey et al. and thanks to @FedericoV and @yoavram @rougier , what is the next step? |
Excellent! Many thanks! |
Next step is the actual publication but the procedure is not really smooth yet. If you have some time to try it and tell what's not clear (new issue) that woudl be great ! Else I can do it. The procedure is described at http://rescience.github.io/edit/ (see editing process). But mostly the goal is to freeze the repo (no more commit or only for obvious error), import it in the ReScience Archives (that will be the official repo) and modify the article such as to add editor/reviewers, change code/data repo links, set the volume (2) issue (1) Once this done, you have to upload the archive to Zenodo (as journal article) and fill the the different fields (don't forget to add the editor field and volume/issue) and the link provided on the page above should make your upload part of the ReScience collection on Zenodo. Last is to tell the original journal a replication has been published confirming the result, but I can do it. |
Nothing is required from you right now. But on the other hand, you can join the board as reviewer if you're interested. Just let me know. |
@tpoisot Do you want to handle the actual publication ? |
I'll handle it. |
@opetchey Can you give me the associated keywords ? |
Yes, sorry about the delay -- was about to leave for a trip but a snow Le jeu 21 avr 2016 à 5:31, Nicolas P. Rougier
|
No problem. Does that mean you can handle the publication ? |
I'd rather let you do it if you can, I'll be sure to look at what the Le jeu 21 avr 2016 à 11:29, Nicolas P. Rougier
|
@rougier Yes, no problem. Keywords: |
This submission has been accepted for publication, and has been published and will soon appear at |
Dear @ReScience/editors,
I request a review for the reproduction of the following paper:
Benincà, E., Huisman, J., Heerkloss, R., Jöhnk, K.D., Branco, P., Van Nes, E.H., Scheffer, M. & Ellner, S.P. (2008) Chaos in a long-term experiment with a plankton community. Nature, 451, 822–825.
I believed the original results have been adequately reproduced as explained in the accompanying article.
The repository lives at https://github.com/opetchey/ReScience-submission/tree/petchey-plebani-pennekamp-2016
Best wishes
Owen Petchey
EDITOR
Feb 23, 2016
March 3, 2016
March 3, 2016
April 5, 2016
April 13, 2016
April 13, 2016