-
-
Notifications
You must be signed in to change notification settings - Fork 239
Commit
This commit does not belong to any branch on this repository, and may belong to a fork outside of the repository.
fix(YouTube - SponsorBlock): Do not auto skip end segments more than …
…once if using a slow playback speed
- Loading branch information
1 parent
5ae2312
commit 88b3ca4
Showing
1 changed file
with
11 additions
and
8 deletions.
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
88b3ca4
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It still skips
outro-segments
multiple times, even on normal speed.88b3ca4
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think it's caused by the newly added 250ms offset fix in
VideoInformation
, where it's moving the skip time back to before the current playback time. I'll make a fix shortly.88b3ca4
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
In one of the recent YT updates the video time hook can now be called with a time that is slightly behind the previous playback time:
revanced: SegmentPlaybackController: setVideoTime: 281993
revanced: SegmentPlaybackController: setVideoTime: 281600
revanced: SegmentPlaybackController: setVideoTime: 282408
revanced: SegmentPlaybackController: setVideoTime: 283409
I just made a change and I think any issues with repeated skip attempts should be fixed.
88b3ca4
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The current time can be hooked where SponsorBlock is being injected. This place draws the seekbar and specifically the code responsible for drawing the knob (current time) can be used. Alternatively the current time text view can be traced back to the method that calls it with the current time. It'll be important to see if these timers work when YouTube is minimized and similar though