Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

bug: Changing language breaks the app UI #530

Closed
4 tasks done
arseniiarsenii opened this issue Nov 23, 2022 · 8 comments · Fixed by #1611
Closed
4 tasks done

bug: Changing language breaks the app UI #530

arseniiarsenii opened this issue Nov 23, 2022 · 8 comments · Fixed by #1611
Assignees
Labels
Bug report Something isn't working

Comments

@arseniiarsenii
Copy link

arseniiarsenii commented Nov 23, 2022

Type

Error at runtime

Bug description

  1. Language list doesn't appear the first time it is opened
  2. Changing the language breaks the apps UI. Element's display their translation keys instead of the actual translation value.

See screencast attached.

Steps to reproduce

  1. Open manager
  2. Go.to settings
  3. Switch the language to another one (I tried Russian)
  4. Restart the app

Android version

Android 12 (Oxygen OS)

Manager version

0.0.41

Target package name

None

Target package version.

None

Installation type

Non-root

Patches selected.

None

Device logs (exported using Manager settings).

None

Installer logs (exported using Installer menu option) [unneeded if issue is not during patching].

No response

Screenshots or videos

Record_2022-11-24-00-05-26.mp4

Solution

No response

Additional context

No response

Acknowledgements

  • I have searched the existing issues and this is a new and no duplicate or related to another open issue.
  • I have written a short but informative title.
  • I filled out all of the requested information in this issue properly.
  • The issue is related solely to the ReVanced Manager
@arseniiarsenii arseniiarsenii added the Bug report Something isn't working label Nov 23, 2022
@arseniiarsenii arseniiarsenii changed the title Changing language breaks the app UI bug: Changing language breaks the app UI Nov 23, 2022
@CennoxX
Copy link

CennoxX commented Nov 24, 2022

  1. I can reproduce the first issue.
  2. It seems currently only the english and hindi jsons are (manually) added to revanced (https://github.com/revanced/revanced-manager/tree/flutter/assets/i18n). For hindi the translation works. So I think:
    • The GitHub integration of Crowdin should be added
    • If a language doesn't exist/has no translated strings, don't show it as possible language
    • If a string is not translated, use the english string, don't show the string-name
  3. Another UI bug: If I set hindi as language, "English" is still displayed as "Language" (see image)
    grafik

@speedlorenzo12
Copy link

Italian is the same issue

@CennoxX
Copy link

CennoxX commented Nov 24, 2022

Italian is the same issue

As said, the issue is the same for every language, except English and Hindi.

@CennoxX CennoxX mentioned this issue Nov 26, 2022
4 tasks
@CennoxX
Copy link

CennoxX commented Nov 26, 2022

In version 0.0.42 now all language assets are added, but the the language list still doesn't appears, and is not opened, even on a second try (this was working in 0.0.41).

@Ushie
Copy link
Member

Ushie commented Nov 28, 2022

Language selection will be removed in the meantime until a fulfilling implementation has been done

@Ushie Ushie closed this as completed Nov 28, 2022
@validcube
Copy link
Member

This issue is potentially fixed in #1450

@validcube validcube reopened this Nov 11, 2023
@validcube validcube linked a pull request Nov 11, 2023 that will close this issue
8 tasks
@Ushie Ushie removed a link to a pull request Nov 21, 2023
8 tasks
@n1cKz1
Copy link

n1cKz1 commented Mar 2, 2024

On v1.19.0-dev.17 which is supposed to fix language specific issues, selecting Greek still results in this:

Screenshot_2024-03-02-15-58-28-524_app revanced manager flutter

@n1cKz1
Copy link

n1cKz1 commented Mar 5, 2024

On v1.19.0-dev.17 which is supposed to fix language specific issues, selecting Greek still results in this:

was this issue resolved or should I create a new issue? I can't test latest dev release for myself since that version crashes on startup for some reason

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Bug report Something isn't working
Projects
None yet
Development

Successfully merging a pull request may close this issue.

6 participants