-
-
Notifications
You must be signed in to change notification settings - Fork 726
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: Allow changing languages #1450
Conversation
This will result in conflict for all PR targeting dev. I suggest that we merged all |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Bleep
ba55815
to
89075c5
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Bloop: The documentation should be updated to mentions that translation must be generated using the command:
dart run slang
because we are not using slang build runner
additionally, the CI should also be updated too
👀 Checkout the full conversation discussed @ Discord/ReVanced (Team chat; private)
https://canary.discord.com/channels/952946952348270622/952987428786941952/1168894670579966012
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
🥞 (Application is) Tested & Approved
Are the translation strings supposed to be included in this PR? They should be added separately by Crowdin |
I'm sure that they aren't supposed to be included because it's out-of-scope, I decided to add translation to this PR because the repository don't have translation merged yet and I don't really know how would I (automatically) add translation to the repository because the translation file have to be renamed from *.json to strings_*.i18n.json |
That change can be done in Crowdin, once this PR is ready to merge |
This PR is ready to be merge into
On top of that, the translation need to be clean up due to missing translation in base language |
Alright, in this case, you can remove the translations via a commit which will be squashed with the rest of the commits |
|
@Ushie Can you assign the person who you refer to in this PR? |
🥞 All of these have been fixed in 3c18c4e. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nice work!, looks good to me
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
🥞 Approved :troll, self-approved
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The only thing that left is to resolve conflicts and rebase changes on of latest dev branch
This fixes multiple issues. Notably; build failure.
Co-authored-by: Pun Butrach <pun.butrach@gmail.com>
No description provided.