Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(PopScope): User able to exit patch screen when the installer is still running #1663

Merged
merged 2 commits into from
Feb 3, 2024
Merged

fix(PopScope): User able to exit patch screen when the installer is still running #1663

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
a56a699
fix: patch screen pop scope
BenjaminHalko Jan 29, 2024
06fa24e
Merge branch 'dev' into fix/pop-scope
BenjaminHalko Feb 2, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 2 additions & 1 deletion lib/ui/views/installer/installer_view.dart
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -17,6 +17,8 @@ class InstallerView extends StatelessWidget {
onViewModelReady: (model) => model.initialize(context),
viewModelBuilder: () => InstallerViewModel(),
builder: (context, model, child) => PopScope(
onPopInvoked: (bool didPop) => model.onWillPop(context),
canPop: false,
validcube marked this conversation as resolved.
Show resolved Hide resolved
child: SafeArea(
top: false,
bottom: model.isPatching,
Expand Down Expand Up @@ -112,7 +114,6 @@ class InstallerView extends StatelessWidget {
),
),
),
onPopInvoked: (bool didPop) => model.onWillPop(context),
),
);
}
Expand Down