ci: Release APK GitHub Attestation #2315
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: validcube <pun.butrach@gmail.com>
Signed-off-by: validcube <pun.butrach@gmail.com>
Signed-off-by: validcube <pun.butrach@gmail.com>
oSumAtrIX
reviewed
Nov 13, 2024
| @@ -63,3 +65,14 @@ jobs: | |||
| KEYSTORE_ENTRY_PASSWORD: ${{ secrets.KEYSTORE_ENTRY_PASSWORD }} | |||
| run: | | |||
| npx semantic-release | |||
|
|
|||
| - name: Find APK file | |||
| id: find_apk | |||
There was a problem hiding this comment.
This is a placeholder from GitHub Copliot inline code suggestions, can be remove.
oSumAtrIX
reviewed
Nov 13, 2024
Comment on lines
+69
to
+78
| - name: Find APK file | ||
| id: find_apk | ||
| run: | | ||
| APK_LOCATION=$(find build/app/outputs/apk/release/ -name "revanced-manager-*.apk") | ||
| echo "APK_LOCATION=$APK_LOCATION" >> $GITHUB_ENV | ||
|
|
||
| - name: 🛰️ Generate artifact attestation | ||
| uses: actions/attest-build-provenance@v1 | ||
| with: | ||
| subject-path: ${{ env.APK_LOCATION }} |
There was a problem hiding this comment.
Can these both steps be merged into one artifact attestation step?
|
👋 It can, but I've trouble getting the wildcard to work. Will try again
later.
…On Thu, Nov 14, 2024, 2:57 AM oSumAtrIX ***@***.***> wrote:
***@***.**** commented on this pull request.
------------------------------
In .github/workflows/release.yml
<#2315 (comment)>
:
> + - name: Find APK file
+ id: find_apk
+ run: |
+ APK_LOCATION=$(find build/app/outputs/apk/release/ -name "revanced-manager-*.apk")
+ echo "APK_LOCATION=$APK_LOCATION" >> $GITHUB_ENV
+
+ - name: 🛰️ Generate artifact attestation
+ uses: ***@***.***
+ with:
+ subject-path: ${{ env.APK_LOCATION }}
Can these both steps be merged into one artifact attestation step?
—
Reply to this email directly, view it on GitHub
<#2315 (review)>,
or unsubscribe
<https://github.com/notifications/unsubscribe-auth/AWGPSOCHH3UMPDQPE2JMUB32AOVMJAVCNFSM6AAAAABRW2CEYSVHI2DSMVQWIX3LMV43YUDVNRWFEZLROVSXG5CSMV3GSZLXHMZDIMZUGI4DMNZYGI>
.
You are receiving this because you were assigned.Message ID:
***@***.***>
|
|
Wouldn't *.apk work? |
|
I've tried that in
9024539
but that doesn't seem to work so I add additional steps to finding the APK.
I might be doing something wrong, if it is, lmk!
…On Thu, Nov 14, 2024, 7:25 AM oSumAtrIX ***@***.***> wrote:
Wouldn't *.apk work?
—
Reply to this email directly, view it on GitHub
<#2315 (comment)>,
or unsubscribe
<https://github.com/notifications/unsubscribe-auth/AWGPSODJQYC23UIBHGYURHT2APUX3AVCNFSM6AAAAABRW2CEYSVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMZDINZVGA4TMMRTHE>
.
You are receiving this because you were assigned.Message ID:
***@***.***>
|
There was a problem hiding this comment.
Copilot reviewed 1 out of 1 changed files in this pull request and generated no suggestions.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Support GitHub Attestation for attesting the binary, matched SLSA requirements level 1 which provide secure provenance for verification of APK before installing onto devices.
ReVanced Manager is eligible for SLSA Level 2 but we would have to build
libaapt.so(and all prebuilts) in the project, but for now, this is out of scope.