Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(YouTube Remember Video Quality & Remember Playback Speed): Localizate toast "Changed default % to %" #2634

Closed
3 tasks done
MarcaDian opened this issue Jan 21, 2024 · 1 comment
Closed
3 tasks done

feat(YouTube Remember Video Quality & Remember Playback Speed): Localizate toast "Changed default % to %" #2634

MarcaDian opened this issue Jan 21, 2024 · 1 comment
Labels
Feature request Requesting a new feature that's not implemented yet

Comments

@MarcaDian
Copy link
Contributor

MarcaDian commented Jan 21, 2024 •
edited
Loading

Feature description

Remember video quality: Currently, the toast is duplicated with the standard toast, but not localized.
Remember Playback Speed: Currently not localized.

It would be great to move this strings from the integration to the patch for easier localization.

Зображення WhatsApp, дата_ 2024-01-21 о 13 12 54_ca5e17ab

Зображення WhatsApp, дата_ 2024-01-21 о 13 40 12_54da98de

Motivation

Fixing localization problems

Acknowledgements

  • This issue is not a duplicate of an existing feature request.
  • I have chosen an appropriate title.
  • All requested information has been provided properly.
@MarcaDian MarcaDian added the Feature request Requesting a new feature that's not implemented yet label Jan 21, 2024
@MarcaDian MarcaDian changed the title feat(YouTube Remember video quality): Localizate toast "Changed default quality to" feat(YouTube Remember video quality & Remember Playback Speed): Localizate toast "Changed default % to %" Jan 21, 2024
@MarcaDian MarcaDian changed the title feat(YouTube Remember video quality & Remember Playback Speed): Localizate toast "Changed default % to %" feat(YouTube Remember Video Quality & Remember Playback Speed): Localizate toast "Changed default % to %" Jan 21, 2024
@LisoUseInAIKyrios
Copy link
Contributor

LisoUseInAIKyrios commented Jan 21, 2024 •
edited
Loading

Translating in app strings is currently in progress.

#1487

@LisoUseInAIKyrios LisoUseInAIKyrios closed this as not planned Won't fix, can't repro, duplicate, stale Jan 21, 2024
Slenderman00 pushed a commit to Slenderman00/revanced-patches-grindr that referenced this issue Jan 31, 2024
@semantic-release-bot
chore(release): 2.184.1-dev.1 [skip ci]
4db8119 
## [2.184.1-dev.1](ReVanced/revanced-patches@v2.184.0...v2.184.1-dev.1) (2023-07-14)

### Bug Fixes

* **youtube/sponsorblock:** fix some segments skipping slightly too late ([ReVanced#2634](ReVanced/revanced-patches#2634)) ([3175431](ReVanced/revanced-patches@73dd87f))
Slenderman00 pushed a commit to Slenderman00/revanced-patches-grindr that referenced this issue Jan 31, 2024
@semantic-release-bot
chore(release): 2.185.0 [skip ci]
795dfab 
# [2.185.0](ReVanced/revanced-patches@v2.184.0...v2.185.0) (2023-07-20)

### Bug Fixes

* allocate for more than eight `LithoFilter` array items ([ReVanced#2643](ReVanced/revanced-patches#2643)) ([fc8660b](ReVanced/revanced-patches@2d8e15b))
* **Sync for Reddit - Disable ads:** fix compatibility with latest version ([1456577](ReVanced/revanced-patches@1275a93))
* **Tiktok - Settings:** bump compatibility ([ReVanced#2656](ReVanced/revanced-patches#2656)) ([6641356](ReVanced/revanced-patches@fbc5c7d))
* **TikTok - Show seekbar:** fix seekbar not always showing ([ReVanced#2660](ReVanced/revanced-patches#2660)) ([f2742f1](ReVanced/revanced-patches@5a16231))
* **Trakt - Unlock pro:** constraint to last known working version ([ReVanced#2662](ReVanced/revanced-patches#2662)) ([324bbde](ReVanced/revanced-patches@84fa088))
* **YouTube - Spoof client:** show video time and chapters while using seekbar ([ReVanced#2607](ReVanced/revanced-patches#2607)) ([9546d12](ReVanced/revanced-patches@da2a216))
* **youtube/sponsorblock:** fix some segments skipping slightly too late ([ReVanced#2634](ReVanced/revanced-patches#2634)) ([3175431](ReVanced/revanced-patches@73dd87f))

### Features

* **youtube:** rename `video-speed` to `playback-speed` ([ReVanced#2642](ReVanced/revanced-patches#2642)) ([77e8639](ReVanced/revanced-patches@fde251d))
tamnguyenchi93 pushed a commit to tamnguyenchi93/revanced-patches that referenced this issue Mar 24, 2024
@semantic-release-bot
chore(release): 2.184.1-dev.1 [skip ci]
3fb8431 
## [2.184.1-dev.1](ReVanced/revanced-patches@v2.184.0...v2.184.1-dev.1) (2023-07-14)

### Bug Fixes

* **youtube/sponsorblock:** fix some segments skipping slightly too late ([ReVanced#2634](ReVanced/revanced-patches#2634)) ([3175431](ReVanced/revanced-patches@3175431))
tamnguyenchi93 pushed a commit to tamnguyenchi93/revanced-patches that referenced this issue Mar 24, 2024
@semantic-release-bot
chore(release): 2.185.0 [skip ci]
ae42167 
# [2.185.0](ReVanced/revanced-patches@v2.184.0...v2.185.0) (2023-07-20)

### Bug Fixes

* allocate for more than eight `LithoFilter` array items ([ReVanced#2643](ReVanced/revanced-patches#2643)) ([fc8660b](ReVanced/revanced-patches@fc8660b))
* **Sync for Reddit - Disable ads:** fix compatibility with latest version ([1456577](ReVanced/revanced-patches@1456577))
* **Tiktok - Settings:** bump compatibility ([ReVanced#2656](ReVanced/revanced-patches#2656)) ([6641356](ReVanced/revanced-patches@6641356))
* **TikTok - Show seekbar:** fix seekbar not always showing ([ReVanced#2660](ReVanced/revanced-patches#2660)) ([f2742f1](ReVanced/revanced-patches@f2742f1))
* **Trakt - Unlock pro:** constraint to last known working version ([ReVanced#2662](ReVanced/revanced-patches#2662)) ([324bbde](ReVanced/revanced-patches@324bbde))
* **YouTube - Spoof client:** show video time and chapters while using seekbar ([ReVanced#2607](ReVanced/revanced-patches#2607)) ([9546d12](ReVanced/revanced-patches@9546d12))
* **youtube/sponsorblock:** fix some segments skipping slightly too late ([ReVanced#2634](ReVanced/revanced-patches#2634)) ([3175431](ReVanced/revanced-patches@3175431))

### Features

* **youtube:** rename `video-speed` to `playback-speed` ([ReVanced#2642](ReVanced/revanced-patches#2642)) ([77e8639](ReVanced/revanced-patches@77e8639))
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
Feature request Requesting a new feature that's not implemented yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@LisoUseInAIKyrios @MarcaDian