Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Configure Dependabot #2642

Closed
wants to merge 8 commits into from
Closed

Configure Dependabot #2642

Show file tree
Hide file tree
Changes from 5 commits
Commits
Show all changes
8 commits
Select commit Hold shift + click to select a range
b5809c5
Update .releaserc
CanerKaraca23 Jan 26, 2024
2953b47
Update package.json
CanerKaraca23 Jan 26, 2024
56db31d
chore(deps): lock file maintenance
renovate[bot] Jan 26, 2024
7aa7bca
Merge pull request #7 from CanerKaraca23/renovate/lock-file-maintenance
CanerKaraca23 Jan 26, 2024
85d902b
Update dependabot.yml
CanerKaraca23 Jan 26, 2024
1cbada5
Update dependabot.yml
CanerKaraca23 Jan 27, 2024
a73fc21
Update .releaserc
CanerKaraca23 Jan 27, 2024
e95a53f
Update dependabot.yml
CanerKaraca23 Jan 27, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
36 changes: 36 additions & 0 deletions .github/dependabot.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -6,17 +6,53 @@ updates:
target-branch: dev
schedule:
interval: monthly
commit-message:
prefix: fix
CanerKaraca23 marked this conversation as resolved.
Show resolved Hide resolved
prefix-development: build
include: scope
oSumAtrIX marked this conversation as resolved.
Show resolved Hide resolved
groups:
actions-dependencies:
update-types:
- "minor"
Comment on lines +12 to +14
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

What does this configuration do?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

What does this configuration do?

Will mark dependencies if it's major, minor or patch update.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

What do you mean mark?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

What do you mean mark?

It will only say if it's major, minor or patch on description.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

What is major, minor or patch? The dependency version? The version after the bump of ReVanced Patches?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

What is major, minor or patch? The dependency version? The version after the bump of ReVanced Patches?

Yes, dependency version. For example, "gson" = 2.10.1 to 3.0.0 is a major update. It only tells this to you. Major updates may break build. It's just a simple thing.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

"gson" = 2.10.1 to 3.0.0 is a major update. It only tells this to you.

Then why are line 14 and 15 included?

- "patch"
- "major"
patterns:
- "*"

- package-ecosystem: npm
labels: []
directory: /
target-branch: dev
schedule:
interval: monthly
commit-message:
prefix: fix
prefix-development: build
include: scope
groups:
dev-dependencies:
update-types:
- "minor"
- "patch"
- "major"
patterns:
- "*"

- package-ecosystem: gradle
labels: []
directory: /
target-branch: dev
schedule:
interval: monthly
commit-message:
prefix: fix
prefix-development: build
include: scope
groups:
maven-dependencies:
update-types:
- "minor"
- "patch"
- "major"
patterns:
- "*"
21 changes: 20 additions & 1 deletion .releaserc
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -9,12 +9,31 @@
"plugins": [
[
"@semantic-release/commit-analyzer", {
"preset": "conventionalcommits",
"releaseRules": [
{ "type": "build", "scope": "Needs bump", "release": "patch" }
{ "type": "build", "scope": "deps", "release": "patch" }
]
}
],
"@semantic-release/release-notes-generator",
{
"preset": "conventionalcommits",
"presetConfig": {
"types": [
{
"type": "feat",
"section": "Features"
},
{
"type": "fix",
"section": "Bug Fixes"
},
{
"type": "build",
"section": "Dependencies and Other Build Updates",
"hidden": false
}
Comment on lines +22 to +35
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is it possible to specify only the build type? Features and fixes are already being added to the changelog.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is it possible to specify only the build type? Features and fixes are already being added to the changelog.

That "hidden": false, if you don’t include it, it’ll default to true, so already hidden.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is not what I am asking. Whats the impact of removing line 23-30

],
"@semantic-release/changelog",
"gradle-semantic-release-plugin",
[
Expand Down
20 changes: 20 additions & 0 deletions package-lock.json
View file
Open in desktop

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

1 change: 1 addition & 0 deletions package.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -4,6 +4,7 @@
"@semantic-release/changelog": "^6.0.3",
"@semantic-release/git": "^10.0.1",
"gradle-semantic-release-plugin": "^1.9.1",
"conventional-changelog-conventionalcommits": "7.0.2",
"semantic-release": "^23.0.0"
}
}