Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: Animate donate heart more lively #168

Merged
merged 8 commits into from
Sep 7, 2024
Merged

feat: Animate donate heart more lively #168

merged 8 commits into from
Sep 7, 2024

Conversation

oSumAtrIX
Copy link
Member

FC0I3odD0r.mp4

@oSumAtrIX oSumAtrIX requested review from Ushie and xafn and removed request for Ushie August 11, 2023 17:28
@revanced-bot
Copy link

Deployed at https://e4b99160.revanced.pages.dev.

@Ushie Ushie changed the title fix(Patches): update patch name search filter feat(donate): improve donate heart animations Aug 11, 2023
@PalmDevs
Copy link
Member

Currently, bigger hearts can make the page overflow. To fix this, you'd have to set overflow-x: hidden on the parent element of the main element. I'm not sure if you're able to do that or not.

@revanced-bot
Copy link

Deployed at https://head.revanced.pages.dev.

@Ushie Ushie marked this pull request as draft November 25, 2023 15:37
@Ushie Ushie removed the request for review from xafn November 25, 2023 15:37
@oSumAtrIX
Copy link
Member Author

@PalmDevs I am not sure what you mean by overflow, nothing seems out of the ordinary

@PalmDevs
Copy link
Member

PalmDevs commented Mar 3, 2024 •
edited
Loading

@PalmDevs I am not sure what you mean by overflow, nothing seems out of the ordinary

Occasionally some big hearts will pop up and go over the screen edge in the animation causing temporary horizontal overflows. I'll attach recording when I'm available.

@oSumAtrIX
Copy link
Member Author

@PalmDevs Can you record the issue? Maybe this can be solved via overflow hidden

@cloudflare-workers-and-pages Cloudflare Workers and Pages
Copy link

cloudflare-workers-and-pages bot commented Mar 3, 2024 •
edited
Loading

Deploying with  Cloudflare Pages  Cloudflare Pages

Latest commit: f9765ad
Status:🚫  Build failed.

View logs

@oSumAtrIX
Merge branch 'dev' into animations
0b33eb1 
# Conflicts:
#	src/routes/donate/DonateHeartAnimation.svelte
@oSumAtrIX oSumAtrIX changed the title feat(donate): improve donate heart animations feat: Animate donate heart more lively Mar 3, 2024
@oSumAtrIX oSumAtrIX requested a review from Ushie March 3, 2024 00:47
@Ushie Ushie marked this pull request as ready for review September 7, 2024 02:12
@Ushie Ushie merged commit 6401aa3 into dev Sep 7, 2024
1 of 2 checks passed
@Ushie Ushie deleted the animations branch September 7, 2024 02:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Ushie Ushie Ushie approved these changes

Assignees

@PalmDevs PalmDevs

Labels
None yet
Projects
Development of ReVanced
Status: Done
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@oSumAtrIX @revanced-bot @PalmDevs @Ushie @KTibow