Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: Correct <Button> semantics by not wrapping the content #221

Merged
merged 1 commit into from
Jan 13, 2024
Merged

fix: Correct <Button> semantics by not wrapping the content #221

merged 1 commit into from
Jan 13, 2024

Conversation

KTibow
Copy link
Contributor

@KTibow KTibow commented Jan 12, 2024 •
edited
Loading

  • don't wrap the whole thing in a <button>, instead just have it directly
    specific reason: accessibility and cleanness
  • remove restProps
    specific reason: unused, lets old stuff sneak through
  • overall: slightly reduce bundle size

@revanced-bot
Copy link

Deployed at https://0ee514fb.revanced.pages.dev.

@oSumAtrIX oSumAtrIX changed the title refactor: simplify <Button> fix: Correct semantics by using a button instead of div Jan 12, 2024
@KTibow KTibow changed the title fix: Correct semantics by using a button instead of div fix: Correct <Button> semantics by not wrapping the content Jan 12, 2024
@KTibow KTibow merged commit 1ad639d into dev Jan 13, 2024
3 checks passed
@Ushie Ushie deleted the patch-simplify-button branch January 20, 2024 23:01
oSumAtrIX pushed a commit that referenced this pull request Mar 3, 2024
@KTibow @oSumAtrIX
fix: Correct <Button> semantics by not wrapping the content (#221)
d1363c7 
refactor: simplify <Button>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@KTibow @revanced-bot