Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: Use icon library instead of SVGs #271

Merged
merged 29 commits into from
Dec 21, 2024
Merged

feat: Use icon library instead of SVGs #271

merged 29 commits into from
Dec 21, 2024

Conversation

madkarmaa
Copy link
Member

What's this?

A simple component that replaces the use of SVGs in the website.

closes #255

@madkarmaa madkarmaa requested review from oSumAtrIX and Ushie December 13, 2024 20:19
@madkarmaa madkarmaa self-assigned this Dec 13, 2024
@madkarmaa madkarmaa linked an issue Dec 13, 2024 that may be closed by this pull request
Issues with icons #255
Closed
oSumAtrIX
oSumAtrIX approved these changes Dec 14, 2024
View reviewed changes
Copy link
Member

@oSumAtrIX oSumAtrIX left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Theres some more resources in the static dir for icons iirc. Should they be possible to replace, please do so in this PR as well.

@oSumAtrIX oSumAtrIX changed the title feat: icons component feat: Use icon library instead of SVGs Dec 14, 2024
@madkarmaa
Copy link
Member Author

madkarmaa commented Dec 14, 2024 •
edited
Loading

Theres some more resources in the static dir for icons iirc. Should they be possible to replace, please do so in this PR as well.

can you explain this further? @oSumAtrIX

@oSumAtrIX
Copy link
Member

See https://github.com/ReVanced/revanced-website/tree/main/static/icons

@madkarmaa madkarmaa requested a review from oSumAtrIX December 15, 2024 17:32
@madkarmaa
Copy link
Member Author

See https://github.com/ReVanced/revanced-website/tree/main/static/icons

everything should be swapped out now

oSumAtrIX
oSumAtrIX reviewed Dec 17, 2024
View reviewed changes
package.json Outdated Show resolved Hide resolved
oSumAtrIX
oSumAtrIX approved these changes Dec 17, 2024
View reviewed changes
Copy link
Member

@oSumAtrIX oSumAtrIX left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

a container for the icon shouldnt be necessary. If you need to change the icon directly, use the components props. If you need to align it or similar, change the outer div.

@madkarmaa madkarmaa requested a review from oSumAtrIX December 18, 2024 20:39
@madkarmaa madkarmaa requested a review from Ushie December 21, 2024 17:04
@Ushie Ushie merged commit f73f54a into dev Dec 21, 2024
1 check failed
@madkarmaa madkarmaa deleted the feat/icons-component branch December 21, 2024 18:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Ushie Ushie Ushie approved these changes

@oSumAtrIX oSumAtrIX Awaiting requested review from oSumAtrIX

Assignees

@madkarmaa madkarmaa

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Issues with icons
3 participants
@madkarmaa @oSumAtrIX @Ushie