Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add addAnyHandler(). #41

Merged
merged 3 commits into from
Feb 24, 2016
Merged

Add addAnyHandler(). #41

merged 3 commits into from
Feb 24, 2016

Conversation

inamiy
Copy link
Member

@inamiy inamiy commented Feb 22, 2016

This pull request is a new feature for #40 to support addAnyHandler()
which works for both event-based & state-based transitions.

See test case: StateMachineEventTests.swift#L382-L446

@inamiy inamiy mentioned this pull request Feb 22, 2016
@inamiy inamiy added this to the 4.1.0 milestone Feb 22, 2016
@sluramod
Copy link

I expected transition to be input parameter of the method, and the handler called only when the transition happened, but regardless of how.

@inamiy
Copy link
Member Author

inamiy commented Feb 23, 2016

@sluramod
Thanks for feedback!
That sounds even better, and I updated code in 1e88704.
Please see updated test case.

@sluramod
Copy link

excellent, thank you.

@inamiy
Copy link
Member Author

inamiy commented Feb 24, 2016

Ready to :shipit:

inamiy added a commit that referenced this pull request Feb 24, 2016
@inamiy inamiy merged commit be66947 into swift/2.0 Feb 24, 2016
@inamiy inamiy deleted the addAnyHandler branch February 24, 2016 13:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants