-
-
Notifications
You must be signed in to change notification settings - Fork 528
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
React 18: Tooltips still not hiding #769
Comments
As a quick fix you can do this until the package is updated:
|
Thank you very much for the quick fix! |
Is there a PR that fixes this issue? Can this quick fix be turned into a PR? |
Correct me if I'm wrong, but commit 064249c solved the React 18 problem, didn't it? |
The last tag (and therefore npm release) was almost a year ago... @aronhelser do you have the permissions to push tags and make a new npm release? |
Seconded on an NPM-update, there's been a lot of bug-fixes over the past year that should be deployed for them to have any value. |
npm was supposed to be automated, and I no longer remember how to do it. If I get a chance I'll look into it... |
Any luck with the NPM update? |
This seems to be an issue with the new Strict mode of React. I was having the same issue even in production but it worked fine after I removed Strict Mode from my app. As a temporary solution until new update rolls out for the package on NPM |
@aronhelser Another month has passed, no update on NPM. Is there really nobody who can update the NPM-package based on the fixed issues of the past 12 months? The project is stone-dead, isn't it? |
Neither of the maintainers are currently working with React. I've been working exclusively in C++ for the past year. I would be happy to give maintainer access to someone willing to work on the project. |
@aronhelser I'd be happy to try and help as an active maintainer (with the spare time I can find for it). Been using this library for quite some time. |
@wwayne kind reminder |
@wwayne gentle nudge |
@aronhelser |
Hello everybody! What is known about the update? |
@roggervalf is this something you could do? |
Do we have any solution for that? I am experiencing the same issue in production. |
@sundarrajendran temporarily, until issue is resolved here, you can replace it with a fork of mine https://www.npmjs.com/package/react-tooltip-rc |
@pdeszynski I would like to point to your package as a maintained version of this package in the readme - is this OK with you? Are you able to help with maintaining the project? I am probably going to mark this project as archived/inactive. |
@alexgurr I know you were interested in possibly being maintainer. Maybe you can coordinate with @pdeszynski ? |
@aronhelser I don't mind, though if you would like to point to a GH repository - then i would suggest to use https://github.com/react-tooltip/react-tooltip so that does not change anymore no matter who the maintainer will be. |
hey @pdeszynski i'm trying to install your library but it's not working. |
@elionntechguy sorry for that 😞 I was playing with github actions to setup builds and I didn't think anyone really uses it yet. Released fixed version with files inside and from now on I promise it will be stable |
@pdeszynski thanks, but i'm still having the problem of the tooltip not closing when you go off it with clickable=true property. Would you be able to help me? |
pinging again @pdeszynski |
Is the issue fixed now...part of npm-package 4.2.21? |
Please open an issue, though I was not able to reproduce that problem https://pdeszynski.github.io/react-tooltip/?path=/story/example-advanced-features--all-props&args=effect:solid;clickable:true |
Yep, still having the issue, setting "strict mode" to false on Next.js seems to do the trick, but is a bit awkward! Hope it gets fixed soon, anyway, thanks for the work! |
I created a tooltip component using Floating UI (that works fine with React 18). It turns out that once you know how to use Floating UI it's pretty simple to create your own highly customizable tooltip, and you don't actually need react-tooltip any more. |
Hi guys, we've released a new version that supports React 18 (with the strict mode), I'll close that issue, please try the latest version. If needs anything else, please let us know, thanks! |
Hey guys, I just migrated to React 18 and seems like experiencing almost the same issue described here. The minor difference is that my tooltip is not hiding only when I apply a custom style on it. Otherwise it works fine, any ideas on that? |
@skident are you using V4 or V5? If on V4, please see if it's possible to upgrade to V5, since we're not maintaining V4 any longer. If on V5, please check this section on the troubleshooting page, or open a new issue with more details. |
@gabrieljablonski, yes I am using V5 and thanks for the troubleshooting page, the problem was with the |
With npm's latest version of react-tooltip (version 4.2.21) tooltips still don't hide.
The text was updated successfully, but these errors were encountered: