Skip to content

arrowColor prop #1079

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
Aug 15, 2023
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions docs/docs/options.mdx
Original file line number Diff line number Diff line change
Expand Up @@ -123,4 +123,5 @@ import { Tooltip } from 'react-tooltip';
| `middlewares` | `Middleware[]` | no | | array of valid `floating-ui` middlewares | Allows for advanced customization. Check the [`floating-ui` docs](https://floating-ui.com/docs/middleware) for more information |
| `border` | `CSSProperties['border']` | no | | a CSS border style | Change the style of the tooltip border (including the arrow) |
| `opacity` | `CSSProperties['opacity']` | no | `0.9` | a CSS opacity value | Change the opacity of the tooltip |
| `arrowColor` | `CSSProperties['backgroundColor']` | no | | a CSS background color | Change color of the tooltip arrow |
| `disableStyleInjection` | <code>`boolean` &#124; `'core'`</code> | no | `false` | `true` `false` `'core'` | Whether to disable automatic style injection. Do not set dynamically. Check the [styling page](./examples/styling#disabling-reacttooltip-css) for more details |
2 changes: 1 addition & 1 deletion docs/docs/upgrade-guide/changelog-v4-v5.md
Original file line number Diff line number Diff line change
Expand Up @@ -68,7 +68,7 @@ If you run into any problems with the tooltip not updating after changes are mad
- [ ] `textColor` - use `className` and custom CSS
- [ ] `backgroundColor` - use `className` and custom CSS
- [ ] `borderColor` - use `border` prop
- [ ] `arrowColor` - use `className` and custom CSS
- [x] `arrowColor`
- [ ] `arrowRadius` - use `className` and custom CSS
- [ ] `tooltipRadius` - use `className` and custom CSS
- [ ] `insecure`
Expand Down
8 changes: 7 additions & 1 deletion src/components/Tooltip/Tooltip.tsx
Original file line number Diff line number Diff line change
Expand Up @@ -47,6 +47,7 @@ const Tooltip = ({
setActiveAnchor,
border,
opacity,
arrowColor,
}: ITooltip) => {
const tooltipRef = useRef<HTMLElement>(null)
const tooltipArrowRef = useRef<HTMLElement>(null)
Expand Down Expand Up @@ -654,7 +655,12 @@ const Tooltip = ({
[coreStyles['noArrow']]: noArrow,
},
)}
style={inlineArrowStyles}
style={{
...inlineArrowStyles,
background: arrowColor
? `linear-gradient(to right bottom, transparent 50%, ${arrowColor} 50%)`
: undefined,
}}
ref={tooltipArrowRef}
/>
</WrapperElement>
Expand Down
1 change: 1 addition & 0 deletions src/components/Tooltip/TooltipTypes.d.ts
Original file line number Diff line number Diff line change
Expand Up @@ -91,4 +91,5 @@ export interface ITooltip {
setActiveAnchor: (anchor: HTMLElement | null) => void
border?: CSSProperties['border']
opacity?: CSSProperties['opacity']
arrowColor?: CSSProperties['backgroundColor']
}
15 changes: 15 additions & 0 deletions src/components/Tooltip/styles.module.css
Original file line number Diff line number Diff line change
Expand Up @@ -8,9 +8,24 @@
.arrow {
width: 8px;
height: 8px;
}

[class*='react-tooltip__place-top'] > .arrow {
transform: rotate(45deg);
}

[class*='react-tooltip__place-right'] > .arrow {
transform: rotate(135deg);
}

[class*='react-tooltip__place-bottom'] > .arrow {
transform: rotate(225deg);
}

[class*='react-tooltip__place-left'] > .arrow {
transform: rotate(315deg);
}

/** Types variant **/
.dark {
background: var(--rt-color-dark);
Expand Down
2 changes: 2 additions & 0 deletions src/components/TooltipController/TooltipController.tsx
Original file line number Diff line number Diff line change
Expand Up @@ -47,6 +47,7 @@ const TooltipController = ({
disableStyleInjection = false,
border,
opacity,
arrowColor,
setIsOpen,
afterShow,
afterHide,
Expand Down Expand Up @@ -334,6 +335,7 @@ const TooltipController = ({
isOpen,
border,
opacity,
arrowColor,
setIsOpen,
afterShow,
afterHide,
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -69,6 +69,7 @@ export interface ITooltipController {
*/
border?: CSSProperties['border']
opacity?: CSSProperties['opacity']
arrowColor?: CSSProperties['backgroundColor']
setIsOpen?: (value: boolean) => void
afterShow?: () => void
afterHide?: () => void
Expand Down
12 changes: 4 additions & 8 deletions src/utils/compute-positions.ts
Original file line number Diff line number Diff line change
Expand Up @@ -44,14 +44,10 @@ export const computeTooltipPosition = async ({
left: 'right',
}[placement.split('-')[0]] ?? 'bottom'

const borderSide =
border &&
{
top: { borderBottom: border, borderRight: border },
right: { borderBottom: border, borderLeft: border },
bottom: { borderTop: border, borderLeft: border },
left: { borderTop: border, borderRight: border },
}[placement.split('-')[0]]
const borderSide = border && {
borderBottom: border,
borderRight: border,
}

let borderWidth = 0
if (border) {
Expand Down