Skip to content

Removing componentWillMount #106

@JeroenReumkens

Description

@JeroenReumkens

Hi,

Currently the React team is preparing for Concurrent Mode (previously known as Async Mode). To prepare my own app for that, I started wrapping my app in <React.StrictMode>. By doing so I noticed that React Media still implements componentWillMount, something the team advices to remove as soon as possible to prepare for concurrent mode. See https://reactjs.org/docs/react-component.html#unsafe_componentwillmount

I was wondering if there are any plans in removing this (maybe changing it to componentDidMount will already be sufficient?

I'm happy to make a PR if you can confirm changing this should work.

Thanks for all the effort!

Metadata

Metadata

Assignees

No one assigned

    Labels

    No labels
    No labels

    Type

    No type

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions