Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: cancel pending enter/change hooks on location change #4063

Merged
merged 2 commits into from
Oct 25, 2016

Conversation

alisd23
Copy link
Contributor

@alisd23 alisd23 commented Oct 18, 2016

Fix for #3220.

This prevents a redirect from old transitions happening. If a new transition occurs after an async hook with a redirect starts, the new location should take precedence, so the redirect is ignored.

See new tests for situations where this might occur

Also fixed npm tasks on windows again whilst I was there 😄

@alisd23 alisd23 added this to the v3.0.0 milestone Oct 18, 2016
@alisd23 alisd23 changed the title feat(v3): cancel pending enter/change hooks on location change feat: cancel pending enter/change hooks on location change Oct 18, 2016
@alisd23 alisd23 force-pushed the async-enter-replace-fix branch from fe6e2e6 to f00eedc Compare October 19, 2016 13:28
@timdorr
Copy link
Member

timdorr commented Oct 25, 2016

I've been over this in my head a few times. I don't think I can punch any holes in it right now, so I think this is good as-is. Of course, when we push 3.0 I may end up eating my words :P

@timdorr timdorr merged commit 684248e into remix-run:v3 Oct 25, 2016
@alisd23
Copy link
Contributor Author

alisd23 commented Oct 25, 2016

@timdorr It's alright I'll take half the blame 😆

@lock lock bot locked as resolved and limited conversation to collaborators Jan 19, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants