Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Coverage-dependent thermochemistry for catalysis #2646

Open
wants to merge 29 commits into
base: main
Choose a base branch
from
Open

Coverage-dependent thermochemistry for catalysis #2646

wants to merge 29 commits into from

Commits on Jul 18, 2024

  1. Add thermodynamic coverage dependent models in surface reactor

    @12Chao
    12Chao committed Jul 18, 2024
    Configuration menu
    Copy the full SHA
    86b6564 View commit details
    Browse the repository at this point in the history

  2. add thermo coverage dependence instance while reading the file

    @12Chao
    12Chao committed Jul 18, 2024
    Configuration menu
    Copy the full SHA
    0b0b3a8 View commit details
    Browse the repository at this point in the history

  3. add import copy package

    @12Chao
    12Chao committed Jul 18, 2024
    Configuration menu
    Copy the full SHA
    6280df4 View commit details
    Browse the repository at this point in the history

  4. add the instances for thermo coverage dependence

    @12Chao
    12Chao committed Jul 18, 2024
    Configuration menu
    Copy the full SHA
    515f883 View commit details
    Browse the repository at this point in the history

  5. add polynomial thermodynamic coverage model to Wilhoit, NASA, and the… 

    …rmodata
    @12Chao
    12Chao committed Jul 18, 2024
    Configuration menu
    Copy the full SHA
    e1e0fd6 View commit details
    Browse the repository at this point in the history

  6. declare _thermo_coverage_dependence in the pxd files

    @12Chao
    12Chao committed Jul 18, 2024
    Configuration menu
    Copy the full SHA
    29feff2 View commit details
    Browse the repository at this point in the history

  7. fix the typos, and add the missing import command line

    @12Chao
    12Chao committed Jul 18, 2024
    Configuration menu
    Copy the full SHA
    64bfab6 View commit details
    Browse the repository at this point in the history

  8. Add thermo_coverage_dependence as new property to NASA

    @12Chao
    12Chao committed Jul 18, 2024
    Configuration menu
    Copy the full SHA
    2aed70b View commit details
    Browse the repository at this point in the history

  9. Move thermo_coverage_dependence from NASAPolynomial to NASA

    @12Chao
    12Chao committed Jul 18, 2024
    Configuration menu
    Copy the full SHA
    4c98a7a View commit details
    Browse the repository at this point in the history

  10. Add unit test for coverage dependent thermodynamics in RMG thermo cla… 

    …sses
    @12Chao
    12Chao committed Jul 18, 2024
    Configuration menu
    Copy the full SHA
    da66acb View commit details
    Browse the repository at this point in the history

  11. check thermo_coverage_dependence is not empty

    @12Chao
    12Chao committed Jul 18, 2024
    Configuration menu
    Copy the full SHA
    3129969 View commit details
    Browse the repository at this point in the history

  12. Fix the bug for calculating thermo coverage dependent correct values

    @12Chao
    12Chao committed Jul 18, 2024
    Configuration menu
    Copy the full SHA
    10bd3a0 View commit details
    Browse the repository at this point in the history

  13. add a big matrix for species Gibbs free energy corrections

    @12Chao
    12Chao committed Jul 18, 2024
    Configuration menu
    Copy the full SHA
    0c624c1 View commit details
    Browse the repository at this point in the history

  14. correct Gibbs free energy for each species based on its 3-parameter p… 

    …olynomial thermo coverage depedent model
    @12Chao
    12Chao committed Jul 18, 2024
    Configuration menu
    Copy the full SHA
    95e4ec4 View commit details
    Browse the repository at this point in the history

  15. use stoichiometric matrix to calculate the correct value for Keq

    @12Chao
    12Chao committed Jul 18, 2024
    Configuration menu
    Copy the full SHA
    0540ed5 View commit details
    Browse the repository at this point in the history

  16. Add unit tests for thermo coverage dependent models in surface solver… 

    … tests
    @12Chao
    12Chao committed Jul 18, 2024
    Configuration menu
    Copy the full SHA
    e05847c View commit details
    Browse the repository at this point in the history

  17. use isomorphic check to check if thermo coverage dependent species ar… 

    …e in the model
    @12Chao
    12Chao committed Jul 18, 2024
    Configuration menu
    Copy the full SHA
    06240ea View commit details
    Browse the repository at this point in the history

  18. delete unused instances

    @12Chao
    12Chao committed Jul 18, 2024
    Configuration menu
    Copy the full SHA
    1a404ec View commit details
    Browse the repository at this point in the history

  19. Add solver unit test for thermodynamic coverage dependent models

    @12Chao
    12Chao committed Jul 18, 2024
    Configuration menu
    Copy the full SHA
    2783016 View commit details
    Browse the repository at this point in the history

  20. save thermo coverage dependent models as numpy arrays instead a list … 

    …of rmg quantities
    @12Chao
    12Chao committed Jul 18, 2024
    Configuration menu
    Copy the full SHA
    6c7b5f9 View commit details
    Browse the repository at this point in the history

  21. create a subclass of numpy array overriding __repr__ method

    @12Chao
    12Chao committed Jul 18, 2024
    Configuration menu
    Copy the full SHA
    1adced1 View commit details
    Browse the repository at this point in the history

  22. create thermo coverage dep polynomial model in numpy array class with… 

    … new __repr__ method
    @12Chao
    12Chao committed Jul 18, 2024
    Configuration menu
    Copy the full SHA
    5e2477c View commit details
    Browse the repository at this point in the history

  23. use adjacency list as the key of thermo cov dep models

    @12Chao
    12Chao committed Jul 18, 2024
    Configuration menu
    Copy the full SHA
    7f8820c View commit details
    Browse the repository at this point in the history

  24. adjust the method to read data from numpy arrays instead list

    @12Chao
    12Chao committed Jul 18, 2024
    Configuration menu
    Copy the full SHA
    645928c View commit details
    Browse the repository at this point in the history

  25. Write thermo coverage dependent data to Cantera yaml file

    @12Chao
    12Chao committed Jul 18, 2024
    Configuration menu
    Copy the full SHA
    03c94e9 View commit details
    Browse the repository at this point in the history

  26. Use chemkin strings instead of labels when writing to yaml files

    @12Chao
    12Chao committed Jul 18, 2024
    Configuration menu
    Copy the full SHA
    4c9418f View commit details
    Browse the repository at this point in the history

  27. Write the thermo coverage dependent data to yaml files in right format

    @12Chao
    12Chao committed Jul 18, 2024
    Configuration menu
    Copy the full SHA
    4e37aad View commit details
    Browse the repository at this point in the history

  28. Add thermo_coverag_dependence as an instance for class RMG

    @12Chao
    12Chao committed Jul 18, 2024
    Configuration menu
    Copy the full SHA
    9bc21d9 View commit details
    Browse the repository at this point in the history

  29. fix the bug that the coverage kinetics cannot be written to chemkin

    @12Chao
    12Chao committed Jul 18, 2024
    Configuration menu
    Copy the full SHA
    ac76967 View commit details
    Browse the repository at this point in the history