This repository has been archived by the owner on Apr 20, 2018. It is now read-only.
Fix sample laziness and bugs #727
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Fixed the unit tests around sample
* Added more unit tests
ghost
added
the
|
I am working on the Perf version of this as well, but I'll submit that separately. |
|
@paulpdaniels ok, but make sure all the tests pass please... |
|
@mattpodwysocki Fixed, I guess I didn't run the whole suite. |
mattpodwysocki
added a commit
that referenced
this pull request
May 29, 2015
|
@paulpdaniels closing this as I found the original implementation was busted in other ways. Check out the current implementation and see if that still fails |
bouzuya
pushed a commit
to bouzuya/RxJS
that referenced
this pull request
Mar 23, 2016
Clarify instructions on how to install this library using npm 3 or npm 2. Avoids issues such as Reactive-Extensions#727 from happening.
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #726 and #683.
Added regression tests for all the the things that broke along the way.