add NotImplementedError test

ReactiveBayes · Mar 15, 2024 · 49570fb · 49570fb
1 parent 2ea3de8
commit 49570fb
Show file tree

Hide file tree

Showing 2 changed files with 12 additions and 0 deletions.
diff --git a/src/plugins/variational_constraints/variational_constraints_engine.jl b/src/plugins/variational_constraints/variational_constraints_engine.jl
@@ -725,6 +725,14 @@ function resolve(model::Model, context::Context, variable::IndexedVariable)
     return __resolve(model, global_label)
 end
 
+resolve(model::Model, context::Context, variable::IndexedVariable{CombinedRange{NTuple{N, Int}, NTuple{N, Int}}}) where {N} = throw(Graphs.NotImplementedError("Cannot resolve factorization constraint for a combined range of dimension > 2."))
+
+
+function resolve(model::Model, context::Context, variable::IndexedVariable{<:CombinedRange})
+    global_label = unroll(context[getname(variable)])[CartesianIndex(firstindex(index(variable))):CartesianIndex(lastindex(index(variable)))]
+    return __resolve(model, global_label)
+end
+
 function resolve(model::Model, context::Context, constraint::FactorizationConstraint)
     vfiltered = filter(variable -> haskey(context, getname(variable)), getvariables(constraint))
     lhs = map(variable -> resolve(model, context, variable), vfiltered)

diff --git a/test/plugins/variational_constraints/variational_constraints_engine_tests.jl b/test/plugins/variational_constraints/variational_constraints_engine_tests.jl
@@ -1248,4 +1248,8 @@ end
         end
     end
 
+    constraints_5 = @constraints begin
+        q(prec, y) = q(prec[(1,1):(3, 3)])q(y)
+    end
+    @test_throws GraphPPL.Graphs.NotImplementedError model = create_terminated_model(uneven_matrix; plugins = PluginsCollection(VariationalConstraintsPlugin(constraints_5)))
 end