Patch constraints over anonymous variables bug #150
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bvdmitri
reviewed
Jan 15, 2024
test/model_zoo.jl
Outdated
| @@ -118,7 +124,7 @@ end | |||
| y[1] ~ Normal(0, 1) | |||
| for i in 2:10 | |||
| y[i] ~ Normal(0, 1) | |||
| x[i] ~ Normal(y[i - 1] + y[i], 1) | |||
| y[i] ~ Normal(y[i - 1] + y[i], 1) | |||
There was a problem hiding this comment.
This is a strange change? and the strange model, what is actually happening here?
The test is correct and the change with the |
|
I reviewed the change, reverted the |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## dev-4.0.0 #150 +/- ##
=============================================
- Coverage 92.44% 92.38% -0.06%
=============================================
Files 9 8 -1
Lines 1417 1406 -11
=============================================
- Hits 1310 1299 -11
Misses 107 107 ☔ View full report in Codecov by Sentry. |
|
AFAIK this is correct, I think we can merge if you also agree |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds the discussed tests and fixes a bug where if a constraint is applied to a node that has an anonymous variable that has two linked variables we didn't throw an error (and also if multiple variables were anonymous we'd throw). There's two things I'd like you to check @bvdmitri :