Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add plugins to 4.0 branch #153

Merged
merged 54 commits into from
Feb 9, 2024
Merged

Add plugins to 4.0 branch #153

merged 54 commits into from
Feb 9, 2024

Conversation

bvdmitri
Copy link
Member

@bvdmitri bvdmitri commented Feb 7, 2024

This PR adds plugins to the codebase of GraphPPL. The PR also introduces major structural changes to the codebase with the purpose of better performance and memory efficiency. Adds more tests and, in principle, should make it easier to integrate the codebase with ReactiveMP.

Thanks for tests @wouterwln :)

I didn't touch the documentation, so it probably is not really valid in some places, but we can fix it in the 4.0.0 branch.

Copy link

codecov bot commented Feb 7, 2024

Codecov Report

Attention: 66 lines in your changes are missing coverage. Please review.

Comparison is base (56609a5) 92.44% compared to head (efae863) 90.26%.
Report is 1 commits behind head on dev-4.0.0.

Files Patch % Lines
src/graph_engine.jl 85.08% 51 Missing ⚠️
...onal_constraints/variational_constraints_engine.jl 94.48% 8 Missing ⚠️
src/plugins/meta/meta.jl 73.33% 4 Missing ⚠️
src/model_macro.jl 93.33% 2 Missing ⚠️
src/plugins_collection.jl 95.65% 1 Missing ⚠️
Additional details and impacted files
@@              Coverage Diff              @@
##           dev-4.0.0     #153      +/-   ##
=============================================
- Coverage      92.44%   90.26%   -2.19%     
=============================================
  Files              9       12       +3     
  Lines           1416     1561     +145     
=============================================
+ Hits            1309     1409     +100     
- Misses           107      152      +45     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@bvdmitri
Copy link
Member Author

bvdmitri commented Feb 9, 2024

Lets proceed and fix the documentation in the 4.0.0 branch

@bvdmitri bvdmitri merged commit 674bcd1 into dev-4.0.0 Feb 9, 2024
4 of 8 checks passed
@wouterwln wouterwln deleted the dev-4.0.0-plugins-system branch February 16, 2024 13:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants