-
Notifications
You must be signed in to change notification settings - Fork 5
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Implement lazy node label for easier datavars construction #155
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This PR also adds an error message for the following case @model function simple_model_with_wrong_indexing()
x ~ MvNormal([ 0.0, 0.0 ], [ 1.0 0.0; 0.0 1.0 ])
y ~ Beta(x[1], x[2])
end
|
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## dev-4.0.0 #155 +/- ##
=============================================
+ Coverage 90.50% 91.06% +0.55%
=============================================
Files 14 14
Lines 1612 1724 +112
=============================================
+ Hits 1459 1570 +111
- Misses 153 154 +1 ☔ View full report in Codecov by Sentry. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds a possibility to create datavar automatically on demand without explicitly specifying their dimensions in advance. This is done by implementing
LazyIndex
which materializes node labels upon usage.Additionally this PR implements a new syntax in the model specification with the
new
operator which will force create a new node label even if it wasn't defined before.