-
Notifications
You must be signed in to change notification settings - Fork 5
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Implement global MeanField and BetheFactorization constraints #172
Implement global MeanField and BetheFactorization constraints #172
Conversation
Great! Could you please also copy the new docstrings for |
@@ -775,6 +776,8 @@ function convert_to_bitsets(model::Model, node::NodeLabel, neighbors, constraint | |||
return result | |||
end | |||
|
|||
apply_constraints!(model::Model, context::Context, constraints) = apply_constraints!(model, context, constraints, ConstraintStack()) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think its only valid for constraints::Constraints
, right?
Also we could add
function apply_constraints!(
model::Model,
context::Context,
constraint::UnspecifiedConstraints
)
nothing
end
or even remove UnspecifiedConstraints
in the favour of BetheFactorization
?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I feel that UnspecifiedConstraints
should still use the default_constraints
, if any are specified, whereas BetheFactorization
overrides these constraints in favour of the Bethe Factorization
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## dev-4.0.0 #172 +/- ##
=============================================
+ Coverage 91.34% 91.69% +0.35%
=============================================
Files 14 14
Lines 1733 1795 +62
=============================================
+ Hits 1583 1646 +63
+ Misses 150 149 -1 ☔ View full report in Codecov by Sentry. |
No description provided.