Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Half-normal node #338

Merged
merged 7 commits into from
Jul 12, 2023
Merged

Add Half-normal node #338

merged 7 commits into from
Jul 12, 2023

Conversation

albertpod
Copy link
Member

No description provided.

@albertpod
Copy link
Member Author

ping @bvdmitri

@albertpod albertpod marked this pull request as ready for review July 7, 2023 14:44
@albertpod
Copy link
Member Author

@bvdmitri note that there are no tests for prod of HalfNormal and Gamma, besides, I can't figure out why check_type_promotion = true fails.

I've also fixed the namings in InverseGamma tests.

@albertpod albertpod changed the title Half normal Add Half-normal node Jul 7, 2023
@codecov
Copy link

codecov bot commented Jul 7, 2023

Codecov Report

Patch coverage: 73.91% and project coverage change: +0.01 🎉

Comparison is base (5c9ca66) 67.44% compared to head (a234d1b) 67.46%.

Additional details and impacted files
@@            Coverage Diff             @@
##           master     #338      +/-   ##
==========================================
+ Coverage   67.44%   67.46%   +0.01%     
==========================================
  Files         210      210              
  Lines        7660     7683      +23     
==========================================
+ Hits         5166     5183      +17     
- Misses       2494     2500       +6     
Impacted Files Coverage Δ
src/ReactiveMP.jl 63.15% <ø> (ø)
src/distributions/normal.jl 90.99% <0.00%> (-0.59%) ⬇️
src/distributions/gamma_inverse.jl 85.71% <75.00%> (-6.60%) ⬇️
src/distributions/gamma.jl 90.24% <84.61%> (-1.07%) ⬇️

☔ View full report in Codecov by Sentry.
📢 Do you have feedback about the report comment? Let us know in this issue.

@bvdmitri
Copy link
Member

The fail in check_type_promotion is probably due to the Inf which is of type Float64

@albertpod
Copy link
Member Author

ping @bvdmitri

@bvdmitri bvdmitri self-requested a review July 11, 2023 15:15
@bvdmitri bvdmitri merged commit 7b81d41 into master Jul 12, 2023
17 checks passed
@bvdmitri bvdmitri deleted the half_normal branch July 12, 2023 15:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants