Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow functional form constraints that are not sub-typed from AbstractFormConstraint #403

Merged
merged 3 commits into from
Jun 17, 2024

Conversation

bvdmitri
Copy link
Member

This PR enables functional form constraints that do not subtype AbstractFormConstraint. This is useful for supporting objects defined in different packages, such as ProjectedTo from ExponentialFamilyProjection.jl.

@bvdmitri bvdmitri requested a review from albertpod June 17, 2024 12:15
Copy link
Member

@albertpod albertpod left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@bvdmitri bvdmitri merged commit de2a145 into main Jun 17, 2024
3 checks passed
@bvdmitri bvdmitri deleted the dev-fform-enhance branch June 17, 2024 13:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants