Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix empty combinations of observables #23

Merged
merged 2 commits into from
May 13, 2022
Merged

Conversation

bvdmitri
Copy link
Member

This PR fixes empty combinations of observables. For convenience empty combinations of observables send completion event immediately.

This commit fixes empty combinations of observables. For convenience empty combinations of observables send completion event immediatelly.
@codecov-commenter
Copy link

codecov-commenter commented May 12, 2022

Codecov Report

Merging #23 (75ecb8d) into master (d56e553) will increase coverage by 0.03%.
The diff coverage is 100.00%.

@@            Coverage Diff             @@
##           master      #23      +/-   ##
==========================================
+ Coverage   77.79%   77.83%   +0.03%     
==========================================
  Files         115      115              
  Lines        3517     3523       +6     
==========================================
+ Hits         2736     2742       +6     
  Misses        781      781              
Impacted Files Coverage Δ
src/observable/collected.jl 95.45% <100.00%> (+0.14%) ⬆️
src/observable/combined.jl 91.52% <100.00%> (+0.29%) ⬆️
src/observable/combined_updates.jl 92.85% <100.00%> (+0.26%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update d56e553...75ecb8d. Read the comment docs.

@bvdmitri bvdmitri merged commit 493c4cc into master May 13, 2022
@bvdmitri bvdmitri deleted the dev-fix-empty-combinations branch June 16, 2022 14:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants