Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

make FakeTimeSource public #30

Merged
merged 3 commits into from
Feb 11, 2023
Merged

make FakeTimeSource public #30

merged 3 commits into from
Feb 11, 2023

Conversation

ho2ri2s
Copy link
Contributor

@ho2ri2s ho2ri2s commented Feb 6, 2023

#29
I would like to use FakeTimeSource that existed in the test package.
If your intention is not to publish FakeTimeSource, please close this PR.

@ychescale9
Copy link
Member

Thanks! Do you mind also updating the Unit testing cache expirations section in the readme?

@ychescale9 ychescale9 merged commit 0cc0900 into ReactiveCircus:main Feb 11, 2023
@ho2ri2s
Copy link
Contributor Author

ho2ri2s commented Feb 11, 2023 •
edited
Loading

@ychescale9
I updated the README!
I am not good at English, so please correct me with suggested change if I am wrong about the nuances.

@ho2ri2s ho2ri2s deleted the move-faketimesource branch February 11, 2023 07:41
@ychescale9
Copy link
Member

Thanks! I can tweak it a little bit.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ychescale9 ychescale9 Awaiting requested review from ychescale9 ychescale9 is a code owner

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@ho2ri2s @ychescale9