Fix CI release git tag push trigger #869
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Apparently GH action's push event filters accept glob patterns and *not* regexes 🤦 Source: https://docs.github.com/en/actions/using-workflows/workflow-syntax-for-github-actions#onpushbranchestagsbranches-ignoretags-ignore That means that the existing tag filter string being a regex wasn't working properly and as such wasn't triggering the expected builds on tag push. To address this, the `on.push.tags` were updated to have separate entries for normal vs `rc` tags, and also tweaked the tag-only jobs' filters to rely on `github.ref_type` instead of inspecting `github.ref`.
p4checo
force-pushed
the
fix-ci-tag-push-trigger
branch
from
ae3b964
to
392196a
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Apparently GH action's push event filters accept glob patterns and not regexes 🤦
Source:
https://docs.github.com/en/actions/using-workflows/workflow-syntax-for-github-actions#onpushbranchestagsbranches-ignoretags-ignore
That means that the existing tag filter string being a regex wasn't working properly and as such wasn't triggering the expected builds on tag push.
To address this, the
on.push.tagswere updated to have separate entries for normal vsrctags, and also tweaked the tag-only jobs' filters to rely ongithub.ref_typeinstead of inspectinggithub.ref.Checklist