Fix race condition issue in combineLatest #402
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is to fix a race condition in the combineLatest function.
I was getting nil pointer exceptions when using combineLatest callback function
f FuncN
with multiple observables which are also using combineLatest.From what I can tell, the race condition is caused when one observable has incremented the counter, but has not yet set the cache variable
s[i] = item.V
Meanwhile, another observable is checking if the counter is equal to the number of observables
atomic.LoadUint32(&counter) == size
and then calling the callback function with the cache variable which now includes a nil value.By moving the counter increment into the lock, this should fix the race condition issue.