Implement observable and emitter interfaces #71
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 3 commits
November 2, 2018 14:09
Some grammatical errors
Change the subscribe function to return rx.Emitter. Add new test to check observable implements interface. Modify old tests to consume observable.
|
Hi there! I'd really like to see this repo go somewhere, so I implemented some of the interfaces on the rx-interface branch. Not sure I agree with how the current emitter interface would help with closing the subscription though. |
|
I've already done it, a year ago. I've merged the changes into dev branch. The changes are stored here: #28 |
|
Huh, maybe I'm confused. What's the current direction of the project? |
|
@AndreasAbdi see the meaning that Rxgo 2 is going on this issue #99 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The observable's subscribe function is modified to consume an observer and return a subscription.
The subscription has been modified to return values from an internal context object.