Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add hasObservers to Subject #1772

Closed
yogurtearl opened this issue Oct 16, 2014 · 3 comments
Closed

Add hasObservers to Subject #1772

yogurtearl opened this issue Oct 16, 2014 · 3 comments
Labels
Enhancement
Milestone
1.0

Comments

@yogurtearl
Copy link

Other implementations of Rx have a hasObservers method on Subject. It would be nice to have this in RxJava.

RxJS:
https://github.com/Reactive-Extensions/RxJS/blob/master/doc/api/subjects/subject.md#rxsubjectprototypehasobservers

Rx.NET
https://rx.codeplex.com/SourceControl/latest#Rx.NET/Source/System.Reactive.Linq/Reactive/Subjects/Subject.cs
@benjchristensen
Copy link
Member

I'm open to that. Want to submit a pull request?

@benjchristensen benjchristensen added this to the 1.x milestone Oct 17, 2014
@simonbasle simonbasle mentioned this issue Oct 27, 2014
Merged
@simonbasle
Copy link
Contributor

went ahead and implemented the method (see pull request)

benjchristensen added a commit that referenced this issue Oct 28, 2014
@benjchristensen
Merge pull request #1802 from simonbasle/hasObservers
e7fa614 
add hasObservers method to Subjects (#1772)
@benjchristensen benjchristensen modified the milestones: 1.0, 1.x Oct 28, 2014
@benjchristensen
Copy link
Member

Merged.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
Enhancement
Projects
None yet
Milestone
1.0
Development

No branches or pull requests
3 participants
@benjchristensen @yogurtearl @simonbasle