Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Rewrite Observable.cache() & Flowable.cache() #6270

Closed
akarnokd opened this issue Oct 29, 2018 · 0 comments
Closed

Rewrite Observable.cache() & Flowable.cache() #6270

akarnokd opened this issue Oct 29, 2018 · 0 comments
Labels
2.x Enhancement PR welcome

Comments

@akarnokd
Copy link
Member

The current implementations of Observable.cache() & Flowable.cache() look old and have several problems:

  • They dispose the upstream when they terminate, which shouldn't happen.
  • They have an extra indirection for their state but not sure why. Probably a structuring remnant from 1.x.
  • The general drain logic seem to use too many variables.

PR welcome.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
2.x Enhancement PR welcome
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@akarnokd