Skip to content

Rewrite Observable.cache() & Flowable.cache() #6270

Closed
@akarnokd

Description

@akarnokd

The current implementations of Observable.cache() & Flowable.cache() look old and have several problems:

  • They dispose the upstream when they terminate, which shouldn't happen.
  • They have an extra indirection for their state but not sure why. Probably a structuring remnant from 1.x.
  • The general drain logic seem to use too many variables.

PR welcome.

Metadata

Metadata

Assignees

No one assigned

    Type

    No type

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions