Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add doOnTerminate to Single/Maybe for consistency #6379

Closed
kennymacleod opened this issue Jan 21, 2019 · 4 comments
Closed

Add doOnTerminate to Single/Maybe for consistency #6379

kennymacleod opened this issue Jan 21, 2019 · 4 comments

Comments

@kennymacleod
Copy link

As mentioned in #5814, there is no doOnTerminate operator on Single or Maybe, but there is on Observable, Flowable and Completable. There doesn't seem to be any reason for this inconsistency, other than it's just an omission.

Yes, you can workaround this using donOnEvent, but can we instead get this operator added just for API consistency?

@akarnokd
Copy link
Member

Okay, PR welcome.

@skryvets
Copy link
Contributor

skryvets commented Jan 22, 2019

@akarnokd, I would like to contribute to this feature, is this issue free to work on? However, even though it seems pretty straightforward, I'm new to this project and it may take some time for me to submit a final PR, is it acceptable? I don't want to block if it's an urgent need and can be done by somebody else in a faster manner. Thanks.

@akarnokd
Copy link
Member

Nobody has started working on this to my knowledge. I suggest you do it either way so you gain experience with doing PRs as well as creating RxJava operators.

@skryvets
Copy link
Contributor

Thanks for the tip. Will do.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants